From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-28988-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1JFODh-0004Xc-HY
	for garchives@archives.gentoo.org; Thu, 17 Jan 2008 06:27:21 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 8929EE08A4;
	Thu, 17 Jan 2008 06:27:19 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 66E4AE08A4
	for <gentoo-dev@lists.gentoo.org>; Thu, 17 Jan 2008 06:27:19 +0000 (UTC)
Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id A47AC6606F;
	Thu, 17 Jan 2008 06:27:18 +0000 (UTC)
Date: Wed, 16 Jan 2008 22:27:16 -0800
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, tsunam@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-misc/boinc:
	boinc-5.8.15.ebuild ChangeLog boinc-5.10.28.ebuild
	boinc-5.5.6.ebuild boinc-5.2.14.ebuild
	boinc-4.72.20050813-r3.ebuild boinc-5.4.11.ebuild
Message-ID: <20080117062716.GA3711@supernova>
References: <E1JFLK0-0006DR-IF@stork.gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1JFLK0-0006DR-IF@stork.gentoo.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Archives-Salt: aa6ce497-a4d3-4465-9365-dcc79ce22bbe
X-Archives-Hash: 621ba2af7111b2a1c914320499cc7581

On 03:21 Thu 17 Jan     , Joshua Jackson (tsunam) wrote:
> 1.1                  sci-misc/boinc/boinc-5.10.28.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-misc/boinc/boinc-5.10.28.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-misc/boinc/boinc-5.10.28.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	append-flags -O3 -funroll-loops -fforce-addr -ffast-math

Something this wacky could really use a comment. Presumably upstream 
highly recommends these flags. Perhaps a custom-cflags USE flag could 
disable them.

> src_install() {
> 	make install DESTDIR=""${D}"" || die "make install failed"

Please use emake, if it works. If not, add a comment.

> 	mkdir "${D}"/var "${D}"/var/lib "${D}"/var/lib/boinc/

`mkdir -p` isn't portable?

> 	cp "${S}"/ca-bundle.crt "${D}"/var/lib/boinc
> 	chown boinc:boinc "${D}"/var/lib/boinc

Could use fowners here.

> 	newinitd "${FILESDIR}"/boinc.init boinc
> 	newconfd "${FILESDIR}"/boinc.conf boinc
> 
> 	make_desktop_entry boinc_gui BOINC boinc Science /var/lib/boinc
> }

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list