[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox-clib: ChangeLog rox-clib-2.1.10.ebuild

[Donnie Berkholz <dberkholz@gentoo.org>]

On 15:53 Thu 06 Dec     , Jim Ramsay (lack) wrote:
> 1.1                  rox-base/rox-clib/rox-clib-2.1.10.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/rox-base/rox-clib/rox-clib-2.1.10.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/rox-base/rox-clib/rox-clib-2.1.10.ebuild?rev=1.1&content-type=text/plain

> src_install() {
> 	local baselibdir="/usr/$(get_libdir)"
> 	local NATIVE_FEED_DIR="/usr/share/0install.net/native_feeds"
> 	local ICON_CACHE_DIR="/var/cache/0install.net/interface_icons"
> 
> 	#  clean up source instead of remove it!
> 	( cd src && make clean )
> 
> 	# remove silly .cvs files
> 	find . -name '.cvs*' | xargs rm -f >/dev/null 2>&1
> 	dodoc ${baselibdir}/${APPNAME}
> 	dodir ${baselibdir}/${APPNAME}
> 	cp -r . "${D}${baselibdir}/${APPNAME}"
> 	(
> 		cd Help
> 		dodoc Authors Changes ToDo README Versions
> 	)

Instead of these subshells to save the original directory, a more common 
technique is pushd/popd. Another possibility is 'cd foo; stuff; cd -', 
but that doesn't stack.

> 	0distutils ROX-CLib.xml > tmp.native_feed || die "0distutilss feed edit failed"
> 	insinto "${baselibdir}/ROX-CLib/"
> 	newins tmp.native_feed ROX-CLib.xml
> 
> 	local feedname
> 	feedname=$(0distutils -e tmp.native_feed) || "0distutils URI escape failed"
> 	dosym "${baselibdir}/ROX-CLib/ROX-CLib.xml" "${NATIVE_FEED_DIR}/${feedname}"
> 
> 	local cachedname
> 	cachedname=$(0distutils -c tmp.native_feed) || "0distutils URI escape failed"
> 	dosym "${baselibdir}/ROX-CLib/.DirIcon" "${ICON_CACHE_DIR}/${cachedname}"
> 
> }

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list