public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/freevo: ChangeLog freevo-1.7.4.ebuild freevo-1.6.1.ebuild freevo-1.5.4-r2.ebuild freevo-1.6.0.ebuild
       [not found] <E1IyZW7-0007nO-46@stork.gentoo.org>
@ 2007-12-01 22:20 ` Donnie Berkholz
  0 siblings, 0 replies; only message in thread
From: Donnie Berkholz @ 2007-12-01 22:20 UTC (permalink / raw
  To: gentoo-dev, rbu

On 21:04 Sat 01 Dec     , Robert Buchholz (rbu) wrote:
> 1.1                  media-tv/freevo/freevo-1.7.4.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/freevo/freevo-1.7.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/freevo/freevo-1.7.4.ebuild?rev=1.1&content-type=text/plain

> 		use dvd && ! (built_with_use media-libs/xine-lib directfb) \
> 			&& ewarn "media-libs/xine-lib was not built with directfb support"
> 		! (built_with_use media-video/mplayer directfb) \
> 			&& ewarn "media-video/mplayer was not built with directfb support"
> 		if ! (built_with_use media-libs/libsdl directfb) ; then
> 			eerror "media-libs/libsdl was not built with directdb support"
> 			eerror "Please re-emerge libsdl with the directfb use flag"
> 			die "directfb use flag specified but no support in libsdl and others"
> 		fi
> 	fi

There's no reason to use subshells for these checks, and more checks I cut.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-12-01 22:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1IyZW7-0007nO-46@stork.gentoo.org>
2007-12-01 22:20 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/freevo: ChangeLog freevo-1.7.4.ebuild freevo-1.6.1.ebuild freevo-1.5.4-r2.ebuild freevo-1.6.0.ebuild Donnie Berkholz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox