public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, rbu@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/freevo: ChangeLog freevo-1.7.4.ebuild freevo-1.6.1.ebuild freevo-1.5.4-r2.ebuild freevo-1.6.0.ebuild
Date: Sat, 1 Dec 2007 14:20:24 -0800	[thread overview]
Message-ID: <20071201222023.GQ11249@supernova> (raw)
In-Reply-To: <E1IyZW7-0007nO-46@stork.gentoo.org>

On 21:04 Sat 01 Dec     , Robert Buchholz (rbu) wrote:
> 1.1                  media-tv/freevo/freevo-1.7.4.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/freevo/freevo-1.7.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/freevo/freevo-1.7.4.ebuild?rev=1.1&content-type=text/plain

> 		use dvd && ! (built_with_use media-libs/xine-lib directfb) \
> 			&& ewarn "media-libs/xine-lib was not built with directfb support"
> 		! (built_with_use media-video/mplayer directfb) \
> 			&& ewarn "media-video/mplayer was not built with directfb support"
> 		if ! (built_with_use media-libs/libsdl directfb) ; then
> 			eerror "media-libs/libsdl was not built with directdb support"
> 			eerror "Please re-emerge libsdl with the directfb use flag"
> 			die "directfb use flag specified but no support in libsdl and others"
> 		fi
> 	fi

There's no reason to use subshells for these checks, and more checks I cut.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



           reply	other threads:[~2007-12-01 22:23 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <E1IyZW7-0007nO-46@stork.gentoo.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071201222023.GQ11249@supernova \
    --to=dberkholz@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=rbu@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox