[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-process/fcron: ChangeLog fcron-3.0.4.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-process/fcron: ChangeLog fcron-3.0.4.ebuild

[Donnie Berkholz]

On 08:54 Fri 09 Nov     , Wolfram Schlich (wschlich) wrote:
> 1.1                  sys-process/fcron/fcron-3.0.4.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&content-type=text/plain

> 	if useq debug; then

use() is useq() now. Dunno whether this is common enough to deserve a 
repoman check.

> 	if ls -1 /var/spool/cron/fcrontabs/* >&/dev/null; then

This particular check ignores ROOT, and so does the rest of 
pkg_postinst(). Seems to me that a cron daemon is a package relatively 
likely to be installed using ROOT, so it's worth fixing.

> 		ewarn
> 		ewarn "WARNING: fcron now uses a dedicated fcron-specific"
> 		ewarn "spooldir /var/spool/fcron instead of the commonly"
> 		ewarn "used /var/spool/cron for several reasons."
> 		ewarn
> 		ewarn "Copying over existing crontabs from /var/spool/cron/fcrontabs"
> 		cp /var/spool/cron/fcrontabs/* /var/spool/fcron/ >&/dev/null \
> 			|| die "failed to migrate existing crontabs"
> 		ewarn "You should now remove /var/spool/cron/fcrontabs!"
> 		ewarn
> 		ewarn "Fixing permissions and ownership of /var/spool/fcron"
> 		chown root:root /var/spool/fcron/* >&/dev/null
> 		chmod 0600 /var/spool/fcron/* >&/dev/null
> 		chown fcron:fcron /var/spool/fcron/*.orig >&/dev/null
> 		chmod 0640 /var/spool/fcron/*.orig >&/dev/null
> 		ewarn
> 		ewarn "*** YOU SHOULD IMMEDIATELY UPDATE THE"
> 		ewarn "*** fcrontabs ENTRY IN /etc/fcron/fcron.conf"
> 		ewarn "*** AND RESTART YOUR FCRON DAEMON!"
> 		ebeep 20
> 		epause 10

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-process/fcron: ChangeLog fcron-3.0.4.ebuild

[Wolfram Schlich]

* Donnie Berkholz <dberkholz@gentoo.org> [2007-11-09 10:13]:
> On 08:54 Fri 09 Nov     , Wolfram Schlich (wschlich) wrote:
> > 1.1                  sys-process/fcron/fcron-3.0.4.ebuild
> > 
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&content-type=text/plain
> 
> > 	if useq debug; then
> 
> use() is useq() now. Dunno whether this is common enough to deserve a 
> repoman check.

I won't change that until useq() is going to be finally removed and
that action is *required* then (all of my ebuilds have useq() for
control structures, and I'm not going to change *all at once now*
just because someone has decided to equal use() and useq()... if
someone feels like spending time on that, feel free to care about
it ;)).

> > 	if ls -1 /var/spool/cron/fcrontabs/* >&/dev/null; then
> 
> This particular check ignores ROOT, and so does the rest of 
> pkg_postinst(). Seems to me that a cron daemon is a package relatively 
> likely to be installed using ROOT, so it's worth fixing.

Thanks, fixed :)
-- 
Regards,
Wolfram Schlich <wschlich@gentoo.org>
Gentoo Linux * http://dev.gentoo.org/~wschlich/
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-process/fcron: ChangeLog fcron-3.0.4.ebuild

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Wolfram Schlich kirjoitti:
> * Donnie Berkholz <dberkholz@gentoo.org> [2007-11-09 10:13]:
>> On 08:54 Fri 09 Nov     , Wolfram Schlich (wschlich) wrote:
>>> 1.1                  sys-process/fcron/fcron-3.0.4.ebuild
>>>
>>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&view=markup
>>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&content-type=text/plain
>>> 	if useq debug; then
>> use() is useq() now. Dunno whether this is common enough to deserve a 
>> repoman check.
> 
> I won't change that until useq() is going to be finally removed and
> that action is *required* then (all of my ebuilds have useq() for
> control structures, and I'm not going to change *all at once now*
> just because someone has decided to equal use() and useq()... if
> someone feels like spending time on that, feel free to care about
> it ;)).
> 

I added http://bugs.gentoo.org/show_bug.cgi?id=199722 for nuking useq in
EAPI 2.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-process/fcron: ChangeLog fcron-3.0.4.ebuild

[Wolfram Schlich]

* Petteri Räty <betelgeuse@gentoo.org> [2007-11-20 02:26]:
> Wolfram Schlich kirjoitti:
> > * Donnie Berkholz <dberkholz@gentoo.org> [2007-11-09 10:13]:
> >> On 08:54 Fri 09 Nov     , Wolfram Schlich (wschlich) wrote:
> >>> 1.1                  sys-process/fcron/fcron-3.0.4.ebuild
> >>>
> >>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&view=markup
> >>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&content-type=text/plain
> >>> 	if useq debug; then
> >> use() is useq() now. Dunno whether this is common enough to deserve a 
> >> repoman check.
> > 
> > I won't change that until useq() is going to be finally removed and
> > that action is *required* then (all of my ebuilds have useq() for
> > control structures, and I'm not going to change *all at once now*
> > just because someone has decided to equal use() and useq()... if
> > someone feels like spending time on that, feel free to care about
> > it ;)).
> > 
> 
> I added http://bugs.gentoo.org/show_bug.cgi?id=199722 for nuking useq in
> EAPI 2.

Thanks, I'm Cc:'ed now :)
-- 
Regards,
Wolfram Schlich <wschlich@gentoo.org>
Gentoo Linux * http://dev.gentoo.org/~wschlich/
--
gentoo-dev@gentoo.org mailing list