public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild
Date: Mon, 12 Nov 2007 18:20:31 -0800	[thread overview]
Message-ID: <20071113022031.GJ19458@supernova> (raw)
In-Reply-To: <20071112230318.GB28561@hansmi.ch>

On 00:03 Tue 13 Nov     , Michael Hanselmann wrote:
> On Mon, Nov 12, 2007 at 02:09:33PM -0800, Donnie Berkholz wrote:
> > On 21:47 Mon 12 Nov     , Michael Hanselmann (hansmi) wrote:
> > > pkg_postinst() {
> > > 	chown -R inspircd:inspircd "${ROOT}"/etc/${PN}
> > > 	chmod 700 "${ROOT}"/etc/${PN}
> 
> > > 	chown -R inspircd:inspircd "${ROOT}"/var/log/${PN}
> > > 	chmod 750 "${ROOT}"/var/log/${PN}
> 
> > > 	chown -R inspircd:inspircd "${ROOT}"/usr/$(get_libdir)/${PN}
> > > 	chmod -R 755 "${ROOT}"/usr/$(get_libdir)/${PN}
> 
> > > 	chmod -R 755 "${ROOT}"/usr/bin/inspircd
> > > }
> 
> > Any particular reason this stuff doesn't run in src_install() on the 
> > files while they're in ${D}?
> 
> Honestly, I don't know. The ebuild was contributed quite some time ago.
> Do you think it should be done in src_install instead?

I find it cleaner to move it and use fowners()/fperms(), because doing 
it in pkg_* implies to me that it needs to get fixed on the live 
filesystem for some reason.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



  reply	other threads:[~2007-11-13  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Irh81-0006l9-H9@stork.gentoo.org>
2007-11-12 22:09 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/inspircd: ChangeLog inspircd-1.1.14.ebuild Donnie Berkholz
2007-11-12 23:03   ` Michael Hanselmann
2007-11-13  2:20     ` Donnie Berkholz [this message]
2007-11-13  7:28       ` Peter Volkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071113022031.GJ19458@supernova \
    --to=dberkholz@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox