From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IquJ4-0006q1-FJ for garchives@archives.gentoo.org; Sat, 10 Nov 2007 17:39:43 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.2/8.14.0) with SMTP id lAAHcpCA031576; Sat, 10 Nov 2007 17:38:51 GMT Received: from shuttle.zlin.dk (port78.ds1-abs.adsl.cybercity.dk [212.242.227.17]) by robin.gentoo.org (8.14.2/8.14.0) with ESMTP id lAAHaQMk028382 for ; Sat, 10 Nov 2007 17:36:27 GMT Received: from localhost (localhost [127.0.0.1]) by shuttle.zlin.dk (Postfix) with ESMTP id 3EB4610405D for ; Sat, 10 Nov 2007 18:36:26 +0100 (CET) X-Virus-Scanned: amavisd-new at zlin.dk Received: from shuttle.zlin.dk ([127.0.0.1]) by localhost (shuttle.zlin.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IB+d-nwD2T4N for ; Sat, 10 Nov 2007 18:36:23 +0100 (CET) Received: by shuttle.zlin.dk (Postfix, from userid 1000) id E6E9010407A; Sat, 10 Nov 2007 18:36:23 +0100 (CET) Date: Sat, 10 Nov 2007 18:36:23 +0100 From: Bo =?utf-8?Q?=C3=98rsted?= Andresen To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] repoman and checking for correct quoting Message-ID: <20071110173623.GA32402@shuttle> References: <47358D39.8050901@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <47358D39.8050901@gentoo.org> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: ca9859b2-1671-4bc8-a1e1-527cc6459cf5 X-Archives-Hash: 876eb648eab2a69ba4d2f3028d96d5d1 On Sat, Nov 10, 2007 at 11:51:37AM +0100, Krzysiek Pawlik wrote: > It's purpose is to remove the ${D} from makefile, additionally ${D} is in single > quotes, so it will not be expanded - is it a bug in repoman check? What ${D} ? I see none in that makefile. Which is why I think a patch would be better in this case. A patch would actually tell you when half of the substitutions don't match anything... I think this is a point worth making even if it doesn't change your point. -- Bo Andresen -- gentoo-dev@gentoo.org mailing list