[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-process/fcron: ChangeLog fcron-3.0.4.ebuild

[Donnie Berkholz <dberkholz@gentoo.org>]

On 08:54 Fri 09 Nov     , Wolfram Schlich (wschlich) wrote:
> 1.1                  sys-process/fcron/fcron-3.0.4.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-process/fcron/fcron-3.0.4.ebuild?rev=1.1&content-type=text/plain

> 	if useq debug; then

use() is useq() now. Dunno whether this is common enough to deserve a 
repoman check.

> 	if ls -1 /var/spool/cron/fcrontabs/* >&/dev/null; then

This particular check ignores ROOT, and so does the rest of 
pkg_postinst(). Seems to me that a cron daemon is a package relatively 
likely to be installed using ROOT, so it's worth fixing.

> 		ewarn
> 		ewarn "WARNING: fcron now uses a dedicated fcron-specific"
> 		ewarn "spooldir /var/spool/fcron instead of the commonly"
> 		ewarn "used /var/spool/cron for several reasons."
> 		ewarn
> 		ewarn "Copying over existing crontabs from /var/spool/cron/fcrontabs"
> 		cp /var/spool/cron/fcrontabs/* /var/spool/fcron/ >&/dev/null \
> 			|| die "failed to migrate existing crontabs"
> 		ewarn "You should now remove /var/spool/cron/fcrontabs!"
> 		ewarn
> 		ewarn "Fixing permissions and ownership of /var/spool/fcron"
> 		chown root:root /var/spool/fcron/* >&/dev/null
> 		chmod 0600 /var/spool/fcron/* >&/dev/null
> 		chown fcron:fcron /var/spool/fcron/*.orig >&/dev/null
> 		chmod 0640 /var/spool/fcron/*.orig >&/dev/null
> 		ewarn
> 		ewarn "*** YOU SHOULD IMMEDIATELY UPDATE THE"
> 		ewarn "*** fcrontabs ENTRY IN /etc/fcron/fcron.conf"
> 		ewarn "*** AND RESTART YOUR FCRON DAEMON!"
> 		ebeep 20
> 		epause 10

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list