From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-27534-garchives=archives.gentoo.org@gentoo.org>)
	id 1IqOzl-0001LC-BA
	for garchives@archives.gentoo.org; Fri, 09 Nov 2007 08:13:42 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
	by robin.gentoo.org (8.14.2/8.14.0) with SMTP id lA98Cp9U012527;
	Fri, 9 Nov 2007 08:12:51 GMT
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by robin.gentoo.org (8.14.2/8.14.0) with ESMTP id lA98AuqR010119
	for <gentoo-dev@lists.gentoo.org>; Fri, 9 Nov 2007 08:10:57 GMT
Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id 22CE16534F;
	Fri,  9 Nov 2007 08:10:56 +0000 (UTC)
Date: Fri, 9 Nov 2007 00:10:54 -0800
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, ticho@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-mail/getmail:
	ChangeLog getmail-4.7.7.ebuild
Message-ID: <20071109081054.GY5516@supernova>
References: <E1IqBrM-0003SB-32@stork.gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1IqBrM-0003SB-32@stork.gentoo.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Archives-Salt: 113e98c2-944e-403a-8aa3-0759567ae91f
X-Archives-Hash: a55e3ee2e8f31899a75183fdc72ca8c7

On 18:12 Thu 08 Nov     , Andrej Kacian (ticho) wrote:
> 1.1                  net-mail/getmail/getmail-4.7.7.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-mail/getmail/getmail-4.7.7.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-mail/getmail/getmail-4.7.7.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	distutils_src_compile
> }

This is the default.

> 
> src_install() {
> 	distutils_src_install
> 
> 	if has_version "=net-mail/getmail-3*" ; then
> 		mv ${D}/usr/bin/getmail ${D}/usr/bin/getmail4
> 		mv ${D}/usr/bin/getmail_maildir ${D}/usr/bin/getmail_maildir4
> 		mv ${D}/usr/bin/getmail_mbox ${D}/usr/bin/getmail_mbox4
> 	fi
> 
> 	# handle docs the gentoo way
> 	if [ ${P} != ${PF} ]; then
> 		mv ${D}/usr/share/doc/${P} ${D}/usr/share/doc/${PF}
> 	fi
> 
> 	dodir /usr/share/doc/${PF}/html
> 	mv ${D}/usr/share/doc/${PF}/*.html ${D}/usr/share/doc/${PF}/*.css ${D}/usr/share/doc/${PF}/html
> }

All kinds of quoting issues, did you check repoman warnings?

> 
> pkg_postinst() {
> 	python_version
> 	python_mod_optimize /usr/lib/python${PYVER}/site-packages/getmailcore

Could call distutils_pkg_postinst() instead of these.

> pkg_postrm() {
> 	python_version
> 	python_mod_cleanup
> }

This is the default.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list