From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Ip6ON-00067K-5a for garchives@archives.gentoo.org; Mon, 05 Nov 2007 18:09:43 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.2/8.14.0) with SMTP id lA5I7r6e026564; Mon, 5 Nov 2007 18:07:53 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.2/8.14.0) with ESMTP id lA5I3KsM018436 for ; Mon, 5 Nov 2007 18:03:23 GMT Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 417146577C; Mon, 5 Nov 2007 18:03:23 +0000 (UTC) Date: Mon, 5 Nov 2007 10:03:21 -0800 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org, pva@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-firewall/ipset: ChangeLog metadata.xml ipset-2.3.0.20070828.ebuild Message-ID: <20071105180321.GF25343@supernova> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 86e5f416-7e2e-43e0-bae4-e86c093416a0 X-Archives-Hash: d880417876f4f6cc9a5ec48a762fe605 On 14:23 Mon 05 Nov , Peter Volkov (pva) wrote: > 1.1 net-firewall/ipset/ipset-2.3.0.20070828.ebuild > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-firewall/ipset/ipset-2.3.0.20070828.ebuild?rev=1.1&view=markup > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-firewall/ipset/ipset-2.3.0.20070828.ebuild?rev=1.1&content-type=text/plain > src_defs() { > # these are used in both of src_compile and src_install > myconf="${myconf} PREFIX=" > myconf="${myconf} LIBDIR=/lib" Should this be get_libdir()? Also seems like instead of having a function to do this, you could just define the variables once in pkg_setup() or src_compile() as globals. > pkg_config() { > cd "${ROOT}${PORTAGE_TMPDIR}" > mkdir patch-o-matic-ng > cd patch-o-matic-ng > > IPTVERINS=`echo $(best_version net-firewall/iptables) | \ > sed -n 's:^[^/]*/[[:alpha:]]*-\([0-9]\+\([.][0-9]\+\)*[a-z]\?\(_\(pre\|p\|beta\|alpha\|rc\)[0-9]*\)*\)\(-r[0-9]\+\)\?$:\1:p'` > > einfo "Unpacking patch-o-matic-ng-${POM_PV}" > tar -jxf "${DISTDIR}"/patch-o-matic-ng-${POM_PV}.tar.bz2 || \ > die "Unable to unpack patch-o-matic-ng-${POM_PV}" > einfo "Unpacking iptables-${IPTVERINS}" > tar -jxf "${DISTDIR}"/iptables-${IPTVERINS}.tar.bz2 || \ > die "Unable to unpack iptables-${IPTVERINS}.tar.bz2" Could you just call unpack() here? > einfo "Enter path to your kernel sources, relative to ${ROOT}" > echo -n "[/usr/src/linux]: " > read K_DIR > [ "${ROOT}${K_DIR}" == "/" ] && K_DIR=${ROOT}/usr/src/linux /usr/src/linux should be what's used here, and if they want to change the kernel to affect, they should change where the symlink points instead of having a secondary config mechanism. Thanks, Donnie -- gentoo-dev@gentoo.org mailing list