public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-libs/db: ChangeLog db-4.6.21.ebuild
       [not found] <E1Iokfk-0003Y7-EU@stork.gentoo.org>
@ 2007-11-05  9:07 ` Donnie Berkholz
  0 siblings, 0 replies; only message in thread
From: Donnie Berkholz @ 2007-11-05  9:07 UTC (permalink / raw
  To: gentoo-dev, caleb

On 18:58 Sun 04 Nov     , Caleb Tennis (caleb) wrote:
> 1.1                  sys-libs/db/db-4.6.21.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-libs/db/db-4.6.21.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-libs/db/db-4.6.21.ebuild?rev=1.1&content-type=text/plain

> for (( i=1 ; i<=${PATCHNO} ; i++ )) ; do

> 	for (( i=1 ; i<=${PATCHNO} ; i++ ))

It reads strangely to mix ways of referencing variables like this. If 
it's gonna be a C-style loop, then go all out:

for (( i=1 ; i<=PATCHNO ; i++ ))

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-11-05  9:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Iokfk-0003Y7-EU@stork.gentoo.org>
2007-11-05  9:07 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-libs/db: ChangeLog db-4.6.21.ebuild Donnie Berkholz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox