[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/polipo: ChangeLog polipo-1.0.3.ebuild polipo-1.0.1.ebuild polipo-1.0.0.ebuild polipo-0.9.12-r1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/polipo: ChangeLog polipo-1.0.3.ebuild polipo-1.0.1.ebuild polipo-1.0.0.ebuild polipo-0.9.12-r1.ebuild

[Donnie Berkholz]

On 15:38 Fri 02 Nov     , Alin Nastac (mrness) wrote:
> 1.1 net-proxy/polipo/polipo-1.0.3.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-proxy/polipo/polipo-1.0.3.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-proxy/polipo/polipo-1.0.3.ebuild?rev=1.1&content-type=text/plain

> pkg_setup() {
> 	enewgroup polipo
> 	enewuser polipo -1 -1 /var/cache/polipo polipo
> }

...

> pkg_preinst() {
> 	pkg_setup
> }

What's up with this?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/polipo: ChangeLog polipo-1.0.3.ebuild polipo-1.0.1.ebuild polipo-1.0.0.ebuild polipo-0.9.12-r1.ebuild

[Alin Năstac]

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

Donnie Berkholz wrote:
> On 15:38 Fri 02 Nov     , Alin Nastac (mrness) wrote:
>   
>> 1.1 net-proxy/polipo/polipo-1.0.3.ebuild
>>
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-proxy/polipo/polipo-1.0.3.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-proxy/polipo/polipo-1.0.3.ebuild?rev=1.1&content-type=text/plain
>>     
>
>   
>> pkg_setup() {
>> 	enewgroup polipo
>> 	enewuser polipo -1 -1 /var/cache/polipo polipo
>> }
>>     
>
> ...
>
>   
>> pkg_preinst() {
>> 	pkg_setup
>> }
>>     
>
> What's up with this?
>   

You have to create users and groups in both pkg_ functions:
  - pkg_setup : when installation is performed the usual way, through
compilation
  - pkg_preinst: when installed from binary package (-k)



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/polipo: ChangeLog polipo-1.0.3.ebuild polipo-1.0.1.ebuild polipo-1.0.0.ebuild polipo-0.9.12-r1.ebuild

[Donnie Berkholz]

On 10:37 Sat 03 Nov     , Alin Năstac wrote:
> You have to create users and groups in both pkg_ functions:
>   - pkg_setup : when installation is performed the usual way, through
> compilation
>   - pkg_preinst: when installed from binary package (-k)

You shouldn't, all pkg_* functions should always be run regardless of 
binary or source package. File a portage bug if pkg_setup() isn't 
getting run, don't work around it.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/polipo: ChangeLog polipo-1.0.3.ebuild polipo-1.0.1.ebuild polipo-1.0.0.ebuild polipo-0.9.12-r1.ebuild

[Alin Năstac]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Donnie Berkholz wrote:
> On 10:37 Sat 03 Nov     , Alin Năstac wrote:
>   
>> You have to create users and groups in both pkg_ functions:
>>   - pkg_setup : when installation is performed the usual way, through
>> compilation
>>   - pkg_preinst: when installed from binary package (-k)
>>     
>
> You shouldn't, all pkg_* functions should always be run regardless of 
> binary or source package. File a portage bug if pkg_setup() isn't 
> getting run, don't work around it.
>   

If that is true (dunno, I didn't tested it yet) then someone should
correct http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml .

Quote from the aforementioned document:

    pkg_setup     Use this function to perform any miscellaneous
    prerequisite tasks. This might include checking for an existing
    configuration file. If it is necessary to add users here, you must
    also do this check in pkg_preinst() before the package gets installed.




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/polipo: ChangeLog polipo-1.0.3.ebuild polipo-1.0.1.ebuild polipo-1.0.0.ebuild polipo-0.9.12-r1.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On Saturday 03 November 2007, Alin Năstac wrote:
> Donnie Berkholz wrote:
> > On 10:37 Sat 03 Nov     , Alin Năstac wrote:
> >> You have to create users and groups in both pkg_ functions:
> >>   - pkg_setup : when installation is performed the usual way, through
> >> compilation
> >>   - pkg_preinst: when installed from binary package (-k)
> >
> > You shouldn't, all pkg_* functions should always be run regardless of
> > binary or source package. File a portage bug if pkg_setup() isn't
> > getting run, don't work around it.
>
> If that is true (dunno, I didn't tested it yet)

it is true, please update your package to create the users whenever it's 
appropriate, and only once.

> then someone should 
> correct http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml .
>
> Quote from the aforementioned document:

fixed.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]