[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Donnie Berkholz]

On 15:38 Wed 31 Oct     , Raul Porcel (armin76) wrote:
> 1.1                  net-p2p/deluge/deluge-0.5.6.2.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&content-type=text/plain

> pkg_setup() {
> 	if has_version "<dev-libs/boost-1.34" && \
> 		! built_with_use "dev-libs/boost" threads; then
> 		eerror "dev-libs/boost has to be built with threads USE-flag."
> 		die "Missing threads USE-flag for dev-libs/boost"
> 	fi
> }
> 
> src_compile() {
> 	filter-ldflags -Wl,--as-needed
> 
> 	distutils_src_compile
> }

If you moved the filter-ldflags() call up to pkg_setup(), you could drop 
src_compile() altogether to clean up the ebuild a little.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Marijn Schouten (hkBst)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Donnie Berkholz wrote:
> On 15:38 Wed 31 Oct     , Raul Porcel (armin76) wrote:
>> 1.1                  net-p2p/deluge/deluge-0.5.6.2.ebuild
>>
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&content-type=text/plain
> 
>> pkg_setup() {
>> 	if has_version "<dev-libs/boost-1.34" && \
>> 		! built_with_use "dev-libs/boost" threads; then
>> 		eerror "dev-libs/boost has to be built with threads USE-flag."
>> 		die "Missing threads USE-flag for dev-libs/boost"
>> 	fi
>> }
>>
>> src_compile() {
>> 	filter-ldflags -Wl,--as-needed
>>
>> 	distutils_src_compile
>> }
> 
> If you moved the filter-ldflags() call up to pkg_setup(), you could drop 
> src_compile() altogether to clean up the ebuild a little.

Wouldn't that make binary packages cry?

Marijn

- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHKMiMp/VmCx0OL2wRAuCGAJ9WdFT5k7bGxZCEJOT0hiwjWZafpgCfYh5F
ONjgCrQ0Y8kf7HI/97YU4AU=
=tPfT
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Rémi Cardona]

Marijn Schouten (hkBst) wrote:
> Donnie Berkholz wrote:
>> If you moved the filter-ldflags() call up to pkg_setup(), you could drop 
>> src_compile() altogether to clean up the ebuild a little.
> 
> Wouldn't that make binary packages cry?

In theory, autotools scripts allow users to set env variables only
during the configure phase. Running 'CFLAGS="blah" make' should be
exactly the same as runing make on its own.

So I'd go as far as saying that puting the filter-ldflags() in
src_compile() would not work.

As for what python distutils scripts do exactly ...

Rémi
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Donnie Berkholz]

On 19:25 Wed 31 Oct     , Marijn Schouten (hkBst) wrote:
> Donnie Berkholz wrote:
> > If you moved the filter-ldflags() call up to pkg_setup(), you could drop 
> > src_compile() altogether to clean up the ebuild a little.
> 
> Wouldn't that make binary packages cry?

Binary packages don't do any linking, so they don't pay any attention to 
LDFLAGS.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Wednesday 31 October 2007, Donnie Berkholz wrote:
> On 15:38 Wed 31 Oct     , Raul Porcel (armin76) wrote:
> > 1.1                  net-p2p/deluge/deluge-0.5.6.2.ebuild
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5
> >.6.2.ebuild?rev=1.1&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5
> >.6.2.ebuild?rev=1.1&content-type=text/plain
> >
> > pkg_setup() {
> > 	if has_version "<dev-libs/boost-1.34" && \
> > 		! built_with_use "dev-libs/boost" threads; then
> > 		eerror "dev-libs/boost has to be built with threads USE-flag."
> > 		die "Missing threads USE-flag for dev-libs/boost"
> > 	fi
> > }
> >
> > src_compile() {
> > 	filter-ldflags -Wl,--as-needed
> >
> > 	distutils_src_compile
> > }
>
> If you moved the filter-ldflags() call up to pkg_setup(), you could drop
> src_compile() altogether to clean up the ebuild a little.

a better idea is to fix the problem instead of ignoring it with filter-ldflags
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Donnie Berkholz]

On 02:22 Thu 01 Nov     , Mike Frysinger wrote:
> On Wednesday 31 October 2007, Donnie Berkholz wrote:
> > On 15:38 Wed 31 Oct     , Raul Porcel (armin76) wrote:
> > > 	filter-ldflags -Wl,--as-needed
> >
> > If you moved the filter-ldflags() call up to pkg_setup(), you could drop
> > src_compile() altogether to clean up the ebuild a little.
> 
> a better idea is to fix the problem instead of ignoring it with filter-ldflags

Brilliant, my dear Watson! For anyone who doesn't know how to fix 
--as-needed problems, we've got a guide: 
http://www.gentoo.org/proj/en/qa/asneeded.xml

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list