From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1InbJ3-0001ep-O1 for garchives@archives.gentoo.org; Thu, 01 Nov 2007 14:46:02 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id lA1Ej94Q022079; Thu, 1 Nov 2007 14:45:09 GMT Received: from farragut.cafarelli.fr (farragut.cafarelli.fr [88.191.27.4]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id lA1EhJv8019729 for ; Thu, 1 Nov 2007 14:43:20 GMT Received: from enterprise.cafarelli.fr (voyageur.cafarelli.fr [82.67.159.41]) by farragut.cafarelli.fr (Postfix) with ESMTP id 939BF224B4B for ; Thu, 1 Nov 2007 15:46:41 +0100 (CET) Date: Thu, 1 Nov 2007 15:43:18 +0100 From: Bernard Cafarelli To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/nxserver-freenx: nxserver-freenx-0.7.0-r1.ebuild ChangeLog nxserver-freenx-0.7.1.ebuild Message-ID: <20071101154318.0c351459@enterprise.cafarelli.fr> In-Reply-To: <20071031234235.GU30328@supernova> References: <20071031234235.GU30328@supernova> Organization: Gentoo Foundation, Inc. X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.1; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: a065e81d-21fa-478d-ad6e-68d903f614dd X-Archives-Hash: ee36741bbf6e81d96496aa87708593af Le Wed, 31 Oct 2007 16:42:35 -0700 Donnie Berkholz a =C3=A9crit: > On 19:49 Wed 31 Oct , Bernard Cafarelli (voyageur) wrote: > > 1.1 net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebu= ild > >=20 > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserve= r-freenx/nxserver-freenx-0.7.1.ebuild?rev=3D1.1&view=3Dmarkup > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserve= r-freenx/nxserver-freenx-0.7.1.ebuild?rev=3D1.1&content-type=3Dtext/plain >=20 > > pkg_postinst () { > > usermod -s /usr/bin/nxserver nx || die "Unable to set login shell of n= x user!!" > > usermod -d ${NX_HOME_DIR} nx || die "Unable to set home directory of n= x user!!" >=20 > This isn't safe with ROOT !=3D / and it looks wrong too, you oughta be=20 > using enewuser for this stuff. >=20 > Thanks, > Donnie >=20 The problem is, enewuser can not be used to modify already existing user accounts.This happens if another nxserver was installed before (which uses the same account, but with different shell and home directory).=20 I'll fix ROOT handling in the meantime, this should be better: usermod -s "${ROOT}"/usr/bin/nxserver nx usermod -d "${ROOT}"{NX_HOME_DIR} nx Thanks, --=20 Bernard Cafarelli (Voyageur) NX and GNUstep Gentoo developer -- gentoo-dev@gentoo.org mailing list