From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1InNFP-0001f5-DW for garchives@archives.gentoo.org; Wed, 31 Oct 2007 23:45:19 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9VNiUTp021587; Wed, 31 Oct 2007 23:44:30 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9VNgb6L019190 for ; Wed, 31 Oct 2007 23:42:37 GMT Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id DE62C64CD0; Wed, 31 Oct 2007 23:42:36 +0000 (UTC) Date: Wed, 31 Oct 2007 16:42:35 -0700 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org, voyageur@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/nxserver-freenx: nxserver-freenx-0.7.0-r1.ebuild ChangeLog nxserver-freenx-0.7.1.ebuild Message-ID: <20071031234235.GU30328@supernova> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 8f5eb110-7f90-4444-a639-e301fe36c01b X-Archives-Hash: c64e6506af41892f77f2ac8f825a104c On 19:49 Wed 31 Oct , Bernard Cafarelli (voyageur) wrote: > 1.1 net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild?rev=1.1&view=markup > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/nxserver-freenx/nxserver-freenx-0.7.1.ebuild?rev=1.1&content-type=text/plain > pkg_postinst () { > usermod -s /usr/bin/nxserver nx || die "Unable to set login shell of nx user!!" > usermod -d ${NX_HOME_DIR} nx || die "Unable to set home directory of nx user!!" This isn't safe with ROOT != / and it looks wrong too, you oughta be using enewuser for this stuff. Thanks, Donnie -- gentoo-dev@gentoo.org mailing list