From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1In5an-00063N-7u for garchives@archives.gentoo.org; Wed, 31 Oct 2007 04:54:13 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9V4rMf1027224; Wed, 31 Oct 2007 04:53:22 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9V4p6xP024177 for ; Wed, 31 Oct 2007 04:51:07 GMT Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id BDC1864A38; Wed, 31 Oct 2007 04:51:05 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: Donnie Berkholz Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild Date: Wed, 31 Oct 2007 00:51:03 -0400 User-Agent: KMail/1.9.7 Cc: gentoo-dev@lists.gentoo.org, marineam@gentoo.org References: <200710310031.43815.vapier@gentoo.org> <20071031044841.GH30328@supernova> In-Reply-To: <20071031044841.GH30328@supernova> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1576509.QzOahZ6aNh"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710310051.04539.vapier@gentoo.org> X-Archives-Salt: c91e2b93-48a6-493e-b296-5336e0018f5a X-Archives-Hash: b77c139b9bae13529db64fcd86c75a12 --nextPart1576509.QzOahZ6aNh Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 31 October 2007, Donnie Berkholz wrote: > On 00:31 Wed 31 Oct , Mike Frysinger wrote: > > On Monday 15 October 2007, Donnie Berkholz wrote: > > > On 18:33 Mon 15 Oct , Micheal Marineau (marineam) wrote: > > > > 1.1 app-emulation/xen/xen-3.1.1.ebuild > > > > > > > > file : > > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/x= en > > > >-3.1 .1.ebuild?rev=3D1.1&view=3Dmarkup plain: > > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/x= en > > > >-3.1 .1.ebuild?rev=3D1.1&content-type=3Dtext/plain > > > > > > > > src_compile() { > > > > local myopt > > > > use debug && myopt=3D"${myopt} debug=3Dy" > > > > use pae && myopt=3D"${myopt} pae=3Dy" > > > > > > > > if use custom-cflags; then > > > > filter-flags -fPIE -fstack-protector > > > > else > > > > unset CFLAGS > > > > fi > > > > > > > > # Send raw LDFLAGS so that --as-needed works > > > > emake LDFLAGS=3D"$(raw-ldflags)" -C xen ${myopt} || die "compile > > > > failed" } > > > > > > > > src_install() { > > > > local myopt > > > > use debug && myopt=3D"${myopt} debug=3Dy" > > > > use pae && myopt=3D"${myopt} pae=3Dy" > > > > > > The environment should be preserved across phases, so you shouldn't > > > have to repeat this stuff. > > > > "myopt" is declared "local" > > Sure, but did you notice it's set to the exact thing in both phases? > Seems a bit pointless. i'm not disagreeing on that point, just that "myopt" is not currently part = of=20 the environment so it wont be preserved ;) =2Dmike --nextPart1576509.QzOahZ6aNh Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iQIVAwUARygJuEFjO5/oN/WBAQJhWhAAytFZZzfiHerR+NeW+Pe7qLuVedqF0fVQ faQg8h76z+2B5Lug0rQlWE6UfW/ApzloTuC1m9dZz3DX1iyfWNg/G7OTL67dQIpO Ew0T30mf8c54BSYKp5e5BZSnmH6i8JqRMOnOJFwrHnH8bhQbcXRCLp0wG4yx3UIi 4PI5g4JWR51LSlekCWMFWY6F+9uNN28muKz4X+1bJY+5xCaXQ97PQrsMLm3/aYYR FJuIH4XmFrXoJ7mJDODOazTw1EIIY37voS4Ks2wEXa8rbnwDFbpKLT125Af2sZSR SCmAoflWSOdKNsHYiv+f3MlxNM9nPkf9blWukiJxKsdobk/4W3YuxQUweBzpJlli 6r3xcSJtnJ4gU7Qq+/NtA7Q1/4rUQ6K9lDI5MtHB2CP58fJmSeYd/y4Gz/OkyVX4 S7/oljVHC9laZCVMI71I0wC7ofA4QeQJehoDb10qbthumjavJP6FzlQqhwULNb46 9qY2/bCADNOdQqDkK0KKStdYTY0KIylmQRKSbkZuGksX3Nh6Dn++JGTlzShe3zAY 9ULMDcTf0B9fMgtTaMhZaSEWUBD2U1O2yPY20YV5qEaMdPwSDbZjHMV4hCX4a1Aw 5dj8tmxAS8JKh7k8xY9ki1iNjkfVJ4oi5H+YU2mTt9UH1pz7aNOWUe/Uf9gniqE6 yecl5t3lHoM= =2aR0 -----END PGP SIGNATURE----- --nextPart1576509.QzOahZ6aNh-- -- gentoo-dev@gentoo.org mailing list