* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild
[not found] <E1IhUl3-0006Zm-2F@stork.gentoo.org>
@ 2007-10-15 22:17 ` Donnie Berkholz
2007-10-31 4:31 ` Mike Frysinger
0 siblings, 1 reply; 4+ messages in thread
From: Donnie Berkholz @ 2007-10-15 22:17 UTC (permalink / raw
To: gentoo-dev, marineam
On 18:33 Mon 15 Oct , Micheal Marineau (marineam) wrote:
> 1.1 app-emulation/xen/xen-3.1.1.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1.1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1.1.ebuild?rev=1.1&content-type=text/plain
> src_compile() {
> local myopt
> use debug && myopt="${myopt} debug=y"
> use pae && myopt="${myopt} pae=y"
>
> if use custom-cflags; then
> filter-flags -fPIE -fstack-protector
> else
> unset CFLAGS
> fi
>
> # Send raw LDFLAGS so that --as-needed works
> emake LDFLAGS="$(raw-ldflags)" -C xen ${myopt} || die "compile failed"
> }
>
> src_install() {
> local myopt
> use debug && myopt="${myopt} debug=y"
> use pae && myopt="${myopt} pae=y"
The environment should be preserved across phases, so you shouldn't have
to repeat this stuff.
Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild
2007-10-15 22:17 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild Donnie Berkholz
@ 2007-10-31 4:31 ` Mike Frysinger
2007-10-31 4:48 ` Donnie Berkholz
0 siblings, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2007-10-31 4:31 UTC (permalink / raw
To: gentoo-dev; +Cc: Donnie Berkholz, marineam
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Monday 15 October 2007, Donnie Berkholz wrote:
> On 18:33 Mon 15 Oct , Micheal Marineau (marineam) wrote:
> > 1.1 app-emulation/xen/xen-3.1.1.ebuild
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1
> >.1.ebuild?rev=1.1&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1
> >.1.ebuild?rev=1.1&content-type=text/plain
> >
> > src_compile() {
> > local myopt
> > use debug && myopt="${myopt} debug=y"
> > use pae && myopt="${myopt} pae=y"
> >
> > if use custom-cflags; then
> > filter-flags -fPIE -fstack-protector
> > else
> > unset CFLAGS
> > fi
> >
> > # Send raw LDFLAGS so that --as-needed works
> > emake LDFLAGS="$(raw-ldflags)" -C xen ${myopt} || die "compile failed"
> > }
> >
> > src_install() {
> > local myopt
> > use debug && myopt="${myopt} debug=y"
> > use pae && myopt="${myopt} pae=y"
>
> The environment should be preserved across phases, so you shouldn't have
> to repeat this stuff.
"myopt" is declared "local"
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild
2007-10-31 4:31 ` Mike Frysinger
@ 2007-10-31 4:48 ` Donnie Berkholz
2007-10-31 4:51 ` Mike Frysinger
0 siblings, 1 reply; 4+ messages in thread
From: Donnie Berkholz @ 2007-10-31 4:48 UTC (permalink / raw
To: Mike Frysinger; +Cc: gentoo-dev, marineam
On 00:31 Wed 31 Oct , Mike Frysinger wrote:
> On Monday 15 October 2007, Donnie Berkholz wrote:
> > On 18:33 Mon 15 Oct , Micheal Marineau (marineam) wrote:
> > > 1.1 app-emulation/xen/xen-3.1.1.ebuild
> > >
> > > file :
> > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1
> > >.1.ebuild?rev=1.1&view=markup plain:
> > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen-3.1
> > >.1.ebuild?rev=1.1&content-type=text/plain
> > >
> > > src_compile() {
> > > local myopt
> > > use debug && myopt="${myopt} debug=y"
> > > use pae && myopt="${myopt} pae=y"
> > >
> > > if use custom-cflags; then
> > > filter-flags -fPIE -fstack-protector
> > > else
> > > unset CFLAGS
> > > fi
> > >
> > > # Send raw LDFLAGS so that --as-needed works
> > > emake LDFLAGS="$(raw-ldflags)" -C xen ${myopt} || die "compile failed"
> > > }
> > >
> > > src_install() {
> > > local myopt
> > > use debug && myopt="${myopt} debug=y"
> > > use pae && myopt="${myopt} pae=y"
> >
> > The environment should be preserved across phases, so you shouldn't have
> > to repeat this stuff.
>
> "myopt" is declared "local"
Sure, but did you notice it's set to the exact thing in both phases?
Seems a bit pointless.
Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild
2007-10-31 4:48 ` Donnie Berkholz
@ 2007-10-31 4:51 ` Mike Frysinger
0 siblings, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2007-10-31 4:51 UTC (permalink / raw
To: Donnie Berkholz; +Cc: gentoo-dev, marineam
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
On Wednesday 31 October 2007, Donnie Berkholz wrote:
> On 00:31 Wed 31 Oct , Mike Frysinger wrote:
> > On Monday 15 October 2007, Donnie Berkholz wrote:
> > > On 18:33 Mon 15 Oct , Micheal Marineau (marineam) wrote:
> > > > 1.1 app-emulation/xen/xen-3.1.1.ebuild
> > > >
> > > > file :
> > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen
> > > >-3.1 .1.ebuild?rev=1.1&view=markup plain:
> > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/xen/xen
> > > >-3.1 .1.ebuild?rev=1.1&content-type=text/plain
> > > >
> > > > src_compile() {
> > > > local myopt
> > > > use debug && myopt="${myopt} debug=y"
> > > > use pae && myopt="${myopt} pae=y"
> > > >
> > > > if use custom-cflags; then
> > > > filter-flags -fPIE -fstack-protector
> > > > else
> > > > unset CFLAGS
> > > > fi
> > > >
> > > > # Send raw LDFLAGS so that --as-needed works
> > > > emake LDFLAGS="$(raw-ldflags)" -C xen ${myopt} || die "compile
> > > > failed" }
> > > >
> > > > src_install() {
> > > > local myopt
> > > > use debug && myopt="${myopt} debug=y"
> > > > use pae && myopt="${myopt} pae=y"
> > >
> > > The environment should be preserved across phases, so you shouldn't
> > > have to repeat this stuff.
> >
> > "myopt" is declared "local"
>
> Sure, but did you notice it's set to the exact thing in both phases?
> Seems a bit pointless.
i'm not disagreeing on that point, just that "myopt" is not currently part of
the environment so it wont be preserved ;)
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-31 4:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1IhUl3-0006Zm-2F@stork.gentoo.org>
2007-10-15 22:17 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-emulation/xen: ChangeLog xen-3.1.1.ebuild Donnie Berkholz
2007-10-31 4:31 ` Mike Frysinger
2007-10-31 4:48 ` Donnie Berkholz
2007-10-31 4:51 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox