public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/compiz-fusion-plugins-main: compiz-fusion-plugins-main-0.6.0.ebuild metadata.xml ChangeLog Manifest
       [not found] <E1IkSJX-0000fS-CH@stork.gentoo.org>
@ 2007-10-23 23:20 ` Petteri Räty
  2007-10-23 23:43   ` Hanno Böck
  0 siblings, 1 reply; 2+ messages in thread
From: Petteri Räty @ 2007-10-23 23:20 UTC (permalink / raw
  To: gentoo-dev, hanno

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

Hanno Boeck (hanno) kirjoitti:
> hanno       07/10/23 22:33:31
> 
> S="${WORKDIR}/${P}"

This is the default.

> 
> src_compile() {
> 	econf `use_enable jpeg` || die "econf failed"
> 	emake || die "make failed"
> }

I think it's more common to use the $() syntax for use_enable.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/compiz-fusion-plugins-main: compiz-fusion-plugins-main-0.6.0.ebuild metadata.xml ChangeLog Manifest
  2007-10-23 23:20 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/compiz-fusion-plugins-main: compiz-fusion-plugins-main-0.6.0.ebuild metadata.xml ChangeLog Manifest Petteri Räty
@ 2007-10-23 23:43   ` Hanno Böck
  0 siblings, 0 replies; 2+ messages in thread
From: Hanno Böck @ 2007-10-23 23:43 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Am Mittwoch 24 Oktober 2007 schrieb Petteri Räty:
> Hanno Boeck (hanno) kirjoitti:
> > hanno       07/10/23 22:33:31
> >
> > S="${WORKDIR}/${P}"
>
> This is the default.
>
> > src_compile() {
> > 	econf `use_enable jpeg` || die "econf failed"
> > 	emake || die "make failed"
> > }
>
> I think it's more common to use the $() syntax for use_enable.

I'll do it later today.

They seem to be good candidates for new repoman checks, as we probably have 
tons of them in the tree.

-- 
Hanno Böck		Blog:   http://www.hboeck.de/
GPG: 3DBD3B20		Jabber: hanno@hboeck.de

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-23 23:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1IkSJX-0000fS-CH@stork.gentoo.org>
2007-10-23 23:20 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/compiz-fusion-plugins-main: compiz-fusion-plugins-main-0.6.0.ebuild metadata.xml ChangeLog Manifest Petteri Räty
2007-10-23 23:43   ` Hanno Böck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox