From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IjmS5-0006Td-Ts for garchives@archives.gentoo.org; Mon, 22 Oct 2007 01:51:34 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9M1dsA8026073; Mon, 22 Oct 2007 01:39:54 GMT Received: from mail.genone.homeip.net (dslb-082-083-031-227.pools.arcor-ip.net [82.83.31.227]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9M1c81l023811 for ; Mon, 22 Oct 2007 01:38:08 GMT Received: by mail.genone.homeip.net (Postfix, from userid 460) id 362A4281E3; Mon, 22 Oct 2007 03:36:49 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr0-genone_0.7 (2007-02-13) on lyta.genone.homeip.net X-Spam-Level: X-Spam-Status: No, score=-3.5 required=7.0 tests=ALL_TRUSTED,AWL,BAYES_20 autolearn=ham version=3.1.8-gr0-genone_0.7 Received: from sheridan (sheridan [192.168.0.40]) by mail.genone.homeip.net (Postfix) with SMTP id 7BF36281E3 for ; Mon, 22 Oct 2007 03:36:47 +0200 (CEST) Date: Mon, 22 Oct 2007 03:36:48 +0200 From: Marius Mauch To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Re: repoman - I cannot handle it... Message-Id: <20071022033648.a22f18bf.genone@gentoo.org> In-Reply-To: References: <200710201445.56961.corsair@gentoo.org> <20071021133511.4bf29dfb@sheridan.genone.homeip.net> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.10.11; i686-pc-mingw32) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: 7334f621-6174-4f6a-bfdd-07d7060d9463 X-Archives-Hash: 2fd30057f08bce6bffcb1a4fb81e2b66 On Sun, 21 Oct 2007 23:13:58 +0100 Steve Long wrote: > Marius Mauch wrote: > > But like name_splitted.cpp is buggy as it assumes that a dash > > followed by a digit starts the version part. See > > echo ${PORTDIR}/*-*/* | tr ' ' '\n' | grep '\-[[:digit:]]' > > for some names that break the assumption. > > > Whoops :S Guess I need to change that then :) > > > And no clue what that cvs stuff is supposed to do, as there are no > > packages using that naming pattern, and the (unused) cvs versioning > > extension in portage-2.1 also uses a different pattern. > > > Well the line from portage_versions.py is: > ver_regexp = re.compile("^(cvs\\.)?(\\d+)((\\.\\d+)*)([a-z]?)((_(pre| > p|beta > alpha|rc)\\d*)*)(-r(\\d+))?$") > - which means that a version begins with either a digit or cvs > followed by digit. Not precisely: a digit, or "cvs" followed by a dot and a digit (you got it right in the following, but not in the code posted earlier) > We represented this in bash (for verCompare) as: > ver='^(cvs\.)?([0-9]+)((\.[0-9]+)*)([a-z]?)((_(pre|p|beta|alpha|rc) > [0-9]*)* (-r([0-9]+))?$' > > I think we can use: > CPV='^(.*-.*)/(.*)-(cvs\.)?([0-9]+)((\.[0-9]+)*)([a-z]?)((_(pre|p|beta > alpha|rc)[0-9]*)*)(-r([0-9.]+))?$' Well, categories don't necessarily have to contain a dash (though all official ones do currently). Marius -- gentoo-dev@gentoo.org mailing list