[gentoo-dev] QA question, undefined reference to _getshort

[gentoo-dev] QA question, undefined reference to _getshort

[Hanno Böck]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

Hi,

I'm currently working on ebuilds for openvas (free successor of nessus). Now 
something nags me, I get a QA warning I'm not able to fix:

net-analyzer:openvas-libraries-1.0.0:20071013-001835.log- * hg_dns_axfr.c:85: 
warning: implicit declaration of function '_getshort'

The function _getshort is part of glibc, but it's nowhere referenced in the 
headers. It probably should be in resolv.h.

glibc-source contains two copies of resolv.h, but the one that get's installed 
is missing that reference.

Is this a glibc-bug? Or is this an internal function that shouldn't be used? 
What's the proper fix for that?

For the reference, my openvas-ebuilds (very similar to the nessus ones):
svn co https://svn.hboeck.de/overlay/net-analyzer/


-- 
Hanno Böck		Blog:   http://www.hboeck.de/
GPG: 3DBD3B20		Jabber: hanno@hboeck.de

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] QA question, undefined reference to _getshort

[Rémi Cardona]

Hanno Böck a écrit :
> Hi,
> 
> I'm currently working on ebuilds for openvas (free successor of nessus). Now 
> something nags me, I get a QA warning I'm not able to fix:
> 
> net-analyzer:openvas-libraries-1.0.0:20071013-001835.log- * hg_dns_axfr.c:85: 
> warning: implicit declaration of function '_getshort'

I was under the impression that _* were private glibc functions that 
should not be used. IIRC, those functions cause a lot of harm for 
porting sandbox to gentoo/fbsd.

I'm in no way 100% sure of that, but that's what I remember anyway.

Cheers,

Rémi
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] QA question, undefined reference to _getshort

[Roy Marples]

On Wed, 2007-10-17 at 10:52 +0200, Hanno Böck wrote:
> net-analyzer:openvas-libraries-1.0.0:20071013-001835.log- * hg_dns_axfr.c:85: 
> warning: implicit declaration of function '_getshort'
> 
> The function _getshort is part of glibc, but it's nowhere referenced in the 
> headers. It probably should be in resolv.h.

It's a private function - don't use it.

However, it's not overly complex - here's how it ends up

        #define NS_GET16(s, cp) do { \
        	register u_char *t_cp = (u_char *)(cp); \
        	(s) = ((u_int16_t)t_cp[0] << 8) \
        	    | ((u_int16_t)t_cp[1]) \
        	    ; \
        	(cp) += NS_INT16SZ; \
        } while (0) 


u_int
ns_get16(const u_char *src) {
	u_int dst;
 
	NS_GET16(dst, src);
	return (dst);
}
libresolv_hidden_def (ns_get16)

u_int16_t _getshort(const u_char *src) { return (ns_get16(src)); }

Thanks

Roy

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] QA question, undefined reference to _getshort

[Hanno Böck]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

Any volunteers for writing a patch? :-)

Upstream is very cooperative, if you want to work together with them.

-- 
Hanno Böck		Blog:   http://www.hboeck.de/
GPG: 3DBD3B20		Jabber: hanno@hboeck.de

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] QA question, undefined reference to _getshort

[Roy Marples]

On Thu, 2007-10-18 at 16:28 +0200, Hanno Böck wrote:
> Any volunteers for writing a patch? :-)
> 
> Upstream is very cooperative, if you want to work together with them.

You're a dev aren't you?

I just showed the path, you have to walk it yourself :)

Thanks

Roy

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] QA question, undefined reference to _getshort

[Lars Weiler]

* Roy Marples <uberlord@gentoo.org> [07/10/18 15:50 +0100]:
> You're a dev aren't you?
> 
> I just showed the path, you have to walk it yourself :)

Not every Gentoo (ebuild) Dev can write code in the desired
language...

Regards, Lars

-- 
Lars Weiler  <pylon@gentoo.org>  +49-171-1963258
Instant Messaging     : pylon@jabber.ccc.de
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator
-- 
gentoo-dev@gentoo.org mailing list