From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IhUx4-0001UZ-Nf for garchives@archives.gentoo.org; Mon, 15 Oct 2007 18:46:07 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9FIYNFP013232; Mon, 15 Oct 2007 18:34:23 GMT Received: from mo-p07-ob.rzone.de (mo-p07-ob.rzone.de [81.169.146.189]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9FIW9uD010716 for ; Mon, 15 Oct 2007 18:32:09 GMT Received: from localhost (u-4-248.vpn.RWTH-Aachen.DE [137.226.100.248]) by post.webmailer.de (klopstock mo33) (RZmta 13.4) with ESMTP id c03382j9FEPcP8 for ; Mon, 15 Oct 2007 20:32:08 +0200 (MEST) (envelope-from: ) Date: Mon, 15 Oct 2007 20:31:59 +0200 From: Christian Faulhammer To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild mythtv-0.21_pre14666.ebuild mythtv-0.21_pre14480-r1.ebuild Message-ID: <20071015203159.6b79ab71@gentoo.org> In-Reply-To: <47137B11.1070003@gentoo.org> References: <20071013004453.GM23990@supernova> <4711974B.6010505@gentoo.org> <20071014045010.GS23990@supernova> <47137651.8040503@gentoo.org> <47137849.7030608@utas.edu.au> <47137B11.1070003@gentoo.org> X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.0; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/TvU6rmV.x0WrIx4LtGb.6CI"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-RZG-AUTH: hXn+rC1arvT7Lf9I/zKDqjrgIkrokD1Qxy5bIqfbp9I10BMNL35Kum+fVbT8+ijLtsxBuXaVaEw= X-RZG-CLASS-ID: mo07 X-Archives-Salt: ba21eeeb-caae-4b5d-bc70-c1f8d247471d X-Archives-Hash: c65e73559e4444b398166ea3fb34187b --Sig_/TvU6rmV.x0WrIx4LtGb.6CI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Doug Goldstein : > Jonathan Adamczewski wrote: > > Doug Goldstein wrote: > >> That's what this commits review list feels like. > > Nearly every suggestion (from Donnie and others) has been over some > > issue that relates directly to either correctness or > > maintainability. It doesn't matter if you can "rattle off > > capabilities to a millimeter" - if they're not documented somewhere > > (like, say, in the comments of the ebuild) then the maintainer that > > comes after you gets to go and break it all over again. > Correctness? Fine. Go ahead. Stick $(use_enable xvmc) into the ebuild. > Do it. I dare you. Then try to compile. > Guess what? When it blows up... that's called INcorrect. The opposite > of the right thing. You were kindly asked if is not possible to use, so why do you feel attacked? Do a comment on it and everybody would be fine, even the people that would have to maintain it some time in the future. If you don't like the review process, just ignore it. Reviews are not a way to show what kind of idiot the committer is, but to improve the overall quality of the tree. Nothing more, nothing less. =20 > The maintainer who comes after me would be someone with a experience > with the package. Some bumkin isn't going to come to maintain package > XYZ unless they know or use the package, and guess what? That means > experience. Yes, and the same goes for GNU Emacs, I needed some time to figure out what all those things did and I broke it several times because I tried to be clever. Now we documented it and I think everyone coming after us will have a less hard time to understand it. Better document it, you never know what happens. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/TvU6rmV.x0WrIx4LtGb.6CI Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFHE7IfNQqtfCuFneMRAuDVAJ4/I7ID6u7ZoCHBC+Z4CzbJPQf/OwCfcg78 ZIhVk6w6Ah3g5G5wNpXkUCk= =lRoi -----END PGP SIGNATURE----- --Sig_/TvU6rmV.x0WrIx4LtGb.6CI-- -- gentoo-dev@gentoo.org mailing list