Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-php5/onphp: ChangeLog onphp-0.10.6.ebuild onphp-0.10.4.ebuild onphp-0.10.3.ebuild

[Donnie Berkholz <dberkholz@gentoo.org>]

On 16:52 Sun 14 Oct     , Drake Wyrm wrote:
> Donnie Berkholz <dberkholz@gentoo.org> wrote:
> > On 18:05 Sun 14 Oct     , Konstantin Arkhipov (voxus) wrote:
> > > 1.1                  dev-php5/onphp/onphp-0.10.6.ebuild
> > > 
> > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-php5/onphp/onphp-0.10.6.ebuild?rev=1.1&view=markup
> > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-php5/onphp/onphp-0.10.6.ebuild?rev=1.1&content-type=text/plain
> > 
> > > 	if use doc ; then
> > > 		for doc in `find doc -maxdepth 1 -type f -print` ; do
> > > 			dodoc ${doc}
> > > 		done
> > 
> > You could avoid all these calls to dodoc by saving the docs in a 
> > variable, then calling dodoc on it. Another option could be to send the 
> > loop output to 'xargs dodoc'.
> 
> Or, since you already have the command substitution there, how about:
> 
> 	dodoc `find doc -maxdepth 1 -type f`

Much better than what I said.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list