From: Matti Bickel <mabi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild
Date: Sun, 14 Oct 2007 16:03:22 +0200 [thread overview]
Message-ID: <20071014140322.GA3422@pluto.local> (raw)
In-Reply-To: <fet0nq$2jj$2@ger.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
Steve Long <slong@rathaus.eclipse.co.uk> wrote:
> >> > Mixing 'gt' and 'ge' is a bad idea.
> >>
> >> Just outa curiosity, why?
> >
> > Because it's inconsistent and one generally assumes that people will be
> > consistent with the way they test numbers. That way you only need to
> > read the number rather than continually checking every single line to
> > see how exactly it's tested for.
> >
> I don't see how this is inconsistent either: two tests are needed, so that
> both patches are only applied for >=2.6.22 and first only if >2.6.20.
The point is that if you stick to "ge" OR "gt", everyone could just skip
reading the comparison and focus on the numbers. Will be fixed in the
next release, along with kernel-2.4 support...
--
Regards, Matti Bickel
Signed/Encrypted email preferred (key 4849EC6C)
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-14 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1IghAR-0001BB-Oe@stork.gentoo.org>
2007-10-14 6:30 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild Donnie Berkholz
2007-10-14 6:45 ` Drake Wyrm
2007-10-14 7:50 ` Donnie Berkholz
2007-10-14 12:10 ` [gentoo-dev] " Steve Long
2007-10-14 14:03 ` Matti Bickel [this message]
2007-10-15 21:05 ` [gentoo-dev] " Steve Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071014140322.GA3422@pluto.local \
--to=mabi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox