[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libquicktime: ChangeLog libquicktime-1.0.1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libquicktime: ChangeLog libquicktime-1.0.1.ebuild

[Donnie Berkholz]

On 23:37 Sat 13 Oct     , Alexis Ballier (aballier) wrote:
> 1.1                  media-libs/libquicktime/libquicktime-1.0.1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libquicktime/libquicktime-1.0.1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libquicktime/libquicktime-1.0.1.ebuild?rev=1.1&content-type=text/plain

> pkg_setup() {
> 	if has_version '=x11-base/xorg-x11-6*' && ! built_with_use x11-base/xorg-x11 xv; then
> 		die "You need xv support to compile ${PN}."
> 	fi
> }

This can definitely drop, XOrg 6.x has been gone for ages.

> 		if $(has_version =media-libs/libquicktime-0.9.4); then

You don't need to use command substitution for this, just run it.

> 			elog "It seems this directory belongs to libquicktime-0.9.4."
> 			elog "We'll delete that directory now."
> 			rm -rvf /usr/include/quicktime

ROOT?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/libquicktime: ChangeLog libquicktime-1.0.1.ebuild

[Alexis Ballier]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On Sun, 14 Oct 2007 01:44:42 -0700
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> On 23:37 Sat 13 Oct     , Alexis Ballier (aballier) wrote:
> > 1.1
> > media-libs/libquicktime/libquicktime-1.0.1.ebuild
> > 
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libquicktime/libquicktime-1.0.1.ebuild?rev=1.1&view=markup
> > plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-libs/libquicktime/libquicktime-1.0.1.ebuild?rev=1.1&content-type=text/plain
> 
> > pkg_setup() {
> > 	if has_version '=x11-base/xorg-x11-6*' && ! built_with_use
> > x11-base/xorg-x11 xv; then die "You need xv support to compile
> > ${PN}." fi
> > }
> 
> This can definitely drop, XOrg 6.x has been gone for ages.

dropped, thanks

> > 			elog "It seems this directory belongs to
> > libquicktime-0.9.4." elog "We'll delete that directory now."
> > 			rm -rvf /usr/include/quicktime
> 
> ROOT?


old stuff for compatibility... I've just removed the "try to be clever"
part with quicktime 0.9.4, it shouldn't be very useful now; it just
dies if the directory exists.


Alexis.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]