From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IgzQz-0005ld-QZ for garchives@archives.gentoo.org; Sun, 14 Oct 2007 09:06:54 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9E8u3ns003200; Sun, 14 Oct 2007 08:56:03 GMT Received: from cicero4.cybercity.dk (cicero4.cybercity.dk [212.242.40.52]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9E8rqI7032694 for ; Sun, 14 Oct 2007 08:53:52 GMT Received: from user2.cybercity.dk (user2.cybercity.dk [212.242.41.35]) by cicero4.cybercity.dk (Postfix) with ESMTP id 818C93CBCB5; Sun, 14 Oct 2007 10:53:52 +0200 (CEST) Received: from BA (port78.ds1-abs.adsl.cybercity.dk [212.242.227.17]) by user2.cybercity.dk (Postfix) with SMTP id C19892866AC; Sun, 14 Oct 2007 10:53:51 +0200 (CEST) Received: by BA (sSMTP sendmail emulation); Sun, 14 Oct 2007 10:53:51 +0200 From: Bo =?iso-8859-1?q?=D8rsted_Andresen?= To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-fs/openafs: ChangeLog openafs-1.4.5_pre1.ebuild Date: Sun, 14 Oct 2007 10:53:45 +0200 User-Agent: KMail/1.9.7 Cc: stefaan@gentoo.org References: <20071014083953.GV23990@supernova> In-Reply-To: <20071014083953.GV23990@supernova> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2330939.pHbBaaqIXS"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710141053.50484.bo.andresen@zlin.dk> X-Archives-Salt: 47933203-02a3-4430-a0ff-9d9e8ce37d2e X-Archives-Hash: 6dc8d1ed16d6c5e64f51f0b2c78e2e1e --nextPart2330939.pHbBaaqIXS Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 14 October 2007 10:39:53 Donnie Berkholz wrote: > On 14:25 Sat 13 Oct , Stefaan De Roeck (stefaan) wrote: > > 1.1 net-fs/openafs/openafs-1.4.5_pre1.ebuild > > > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-fs/openafs/o= penafs-1.4.5_pre1.ebuild?rev=3D1.1&view=3Dmarkup > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-fs/openafs/o= penafs-1.4.5_pre1.ebuild?rev=3D1.1&content-type=3Dtext/plain > > > > PATCHDIR=3D${WORKDIR}/gentoo/patches/$(get_version_component_range 1-2) > > CONFDIR=3D${WORKDIR}/gentoo/configs > > SCRIPTDIR=3D${WORKDIR}/gentoo/scripts > > Repoman won't catch these, but they still need quotes. Actually they don't in assignments like these. In the rest of the ebuild ${PATCHDIR}, ${CONFDIR} and ${SCRIPTDIR} need quotes though (the same appli= es to variables such as ${oldafsconfdir}, ${newafsconfdir} etc.). This ebuild = also contains a lot of [ ... ] tests that should either be converted to [[ ... ]= ] or have all variables inside them quoted. =2D-=20 Bo Andresen --nextPart2330939.pHbBaaqIXS Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQBHEdke8/kKEzmwNNoRAoJvAJ9G2j6DoS9o/TLZNW/1MwJ1qRsangCgkByn 1/Kmy9/WSQeOBqVDUEXW4Rg= =BEyd -----END PGP SIGNATURE----- --nextPart2330939.pHbBaaqIXS-- -- gentoo-dev@gentoo.org mailing list