From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IgyRT-00034C-K1 for garchives@archives.gentoo.org; Sun, 14 Oct 2007 08:03:20 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9E7qL5U030097; Sun, 14 Oct 2007 07:52:21 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9E7oN29027751 for ; Sun, 14 Oct 2007 07:50:24 GMT Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 95D796541A for ; Sun, 14 Oct 2007 07:50:23 +0000 (UTC) Date: Sun, 14 Oct 2007 00:50:22 -0700 From: Donnie Berkholz To: gentoo-dev@gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild Message-ID: <20071014075021.GU23990@supernova> References: <20071014063029.GT23990@supernova> <20071014064540.GA27397@phaenix.haell.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071014064540.GA27397@phaenix.haell.com> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 6969fd2b-2516-4f0f-ba26-4a12668e293a X-Archives-Hash: b8ee2cac0d44de4644e0f82b70603f9c On 23:45 Sat 13 Oct , Drake Wyrm wrote: > Donnie Berkholz wrote: > > On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote: > > > if kernel_is gt 2 6 20 ; then > > > epatch "${FILESDIR}"/${PV}-register_sysctl_table.patch > > > fi > > > > > > if kernel_is ge 2 6 22 ; then > > > epatch "${FILESDIR}"/${PV}-kmem-and-dtor-fix.patch > > > fi > > > > Mixing 'gt' and 'ge' is a bad idea. > > Just outa curiosity, why? Because it's inconsistent and one generally assumes that people will be consistent with the way they test numbers. That way you only need to read the number rather than continually checking every single line to see how exactly it's tested for. Thanks, Donnie -- gentoo-dev@gentoo.org mailing list