From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild
Date: Sun, 14 Oct 2007 00:50:22 -0700 [thread overview]
Message-ID: <20071014075021.GU23990@supernova> (raw)
In-Reply-To: <20071014064540.GA27397@phaenix.haell.com>
On 23:45 Sat 13 Oct , Drake Wyrm wrote:
> Donnie Berkholz <dberkholz@gentoo.org> wrote:
> > On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote:
> > > if kernel_is gt 2 6 20 ; then
> > > epatch "${FILESDIR}"/${PV}-register_sysctl_table.patch
> > > fi
> > >
> > > if kernel_is ge 2 6 22 ; then
> > > epatch "${FILESDIR}"/${PV}-kmem-and-dtor-fix.patch
> > > fi
> >
> > Mixing 'gt' and 'ge' is a bad idea.
>
> Just outa curiosity, why?
Because it's inconsistent and one generally assumes that people will be
consistent with the way they test numbers. That way you only need to
read the number rather than continually checking every single line to
see how exactly it's tested for.
Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
next prev parent reply other threads:[~2007-10-14 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1IghAR-0001BB-Oe@stork.gentoo.org>
2007-10-14 6:30 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild Donnie Berkholz
2007-10-14 6:45 ` Drake Wyrm
2007-10-14 7:50 ` Donnie Berkholz [this message]
2007-10-14 12:10 ` [gentoo-dev] " Steve Long
2007-10-14 14:03 ` Matti Bickel
2007-10-15 21:05 ` [gentoo-dev] " Steve Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071014075021.GU23990@supernova \
--to=dberkholz@gentoo.org \
--cc=gentoo-dev@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox