[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/lirc: ChangeLog lirc-0.8.2-r2.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/lirc: ChangeLog lirc-0.8.2-r2.ebuild

[Donnie Berkholz]

On 19:35 Thu 11 Oct     , Matthias Schwarzott (zzam) wrote:
> 1.1                  app-misc/lirc/lirc-0.8.2-r2.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/lirc/lirc-0.8.2-r2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/lirc/lirc-0.8.2-r2.ebuild?rev=1.1&content-type=text/plain

> add_device() {
> 	((lirc_device_count++))

[skip lots of code]

> 	lirc_driver_count=0

"driver" != "device"

Might be useful to initialize it in add_device() if it's unset, so code 
being this far apart won't get out of sync.

> 	make DESTDIR="${D}" install || die "make install failed"

If emake doesn't work, please add a comment to that effect.

> 	newinitd ${FILESDIR}/lircd lircd
> 	newinitd ${FILESDIR}/lircmd lircmd
> 	newconfd ${FILESDIR}/lircd.conf lircd
> 
> 	insinto /etc/modules.d/
> 	newins ${FILESDIR}/modulesd.lirc lirc
> 
> 	newinitd ${FILESDIR}/irexec-initd irexec
> 	newconfd ${FILESDIR}/irexec-confd irexec

Quoting.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/lirc: ChangeLog lirc-0.8.2-r2.ebuild

[Matthias Schwarzott]

On Freitag, 12. Oktober 2007, Donnie Berkholz wrote:
> On 19:35 Thu 11 Oct     , Matthias Schwarzott (zzam) wrote:
> > 1.1                  app-misc/lirc/lirc-0.8.2-r2.ebuild
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/lirc/lirc-0.8.2-
> >r2.ebuild?rev=1.1&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/lirc/lirc-0.8.2-
> >r2.ebuild?rev=1.1&content-type=text/plain
> >
> > add_device() {
> > 	((lirc_device_count++))
>
> [skip lots of code]
>
> > 	lirc_driver_count=0
>
> "driver" != "device"
>
> Might be useful to initialize it in add_device() if it's unset, so code
> being this far apart won't get out of sync.

fixed

>
> > 	make DESTDIR="${D}" install || die "make install failed"
>
> If emake doesn't work, please add a comment to that effect.
>
changed it to emake for ~arch ebuild. Dont want to try that on stable without 
knowing well.

> > 	newinitd ${FILESDIR}/lircd lircd
> > 	newinitd ${FILESDIR}/lircmd lircmd
> > 	newconfd ${FILESDIR}/lircd.conf lircd
> >
> > 	insinto /etc/modules.d/
> > 	newins ${FILESDIR}/modulesd.lirc lirc
> >
> > 	newinitd ${FILESDIR}/irexec-initd irexec
> > 	newconfd ${FILESDIR}/irexec-confd irexec
>
> Quoting.
fixed

Matthias

-- 
Matthias Schwarzott (zzam)
-- 
gentoo-dev@gentoo.org mailing list