[gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild

[gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild

[Tiziano Müller]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2319 bytes --]

Michael Sterrett -Mr. Bones.- wrote:

> On Thu, 11 Oct 2007, Tiziano Müller wrote:
> 
>> Am Dienstag, 9. Oktober 2007 14.56:24 schrieb Doug Goldstein:
>>> Donnie Berkholz wrote:
>>>> On 22:01 Mon 08 Oct     , Doug Goldstein (cardoe) wrote:
>>>>> 1.1                  sys-fs/evms/evms-2.5.5-r8.ebuild
>>>>>
>>>>> file :
>>>>> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
>>>>> 8.ebuild?rev=1.1&view=markup plain:
>>>>> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
>>>>> 8.ebuild?rev=1.1&content-type=text/plain
>>>>>
>>>>> epatch "${FILESDIR}/${PV}/md_super_fix.patch"
>>>>> epatch "${FILESDIR}/${PV}/ntfs_unmkfs.patch"
>>>>> epatch "${FILESDIR}/${PV}/raid5_degrade_fix_v2.patch"
>>>>> epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix.patch"
>>>>> epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix_2.patch"
>>>>> epatch "${FILESDIR}/${PV}/raid5_algorithm.patch"
>>>>> epatch "${FILESDIR}/${PV}/cli_reload_options.patch"
>>>>> epatch "${FILESDIR}/${PV}/cli_query_segfault.patch"
>>>>> epatch "${FILESDIR}/${PV}/get_geometry.patch"
>>>>> epatch "${FILESDIR}/${PV}/BaseName.patch"
>>>>> epatch "${FILESDIR}/${PV}/disk_cache.patch"
>>>>>
>>>>> epatch "${FILESDIR}/${P}-as-needed.patch"
>>>>> epatch "${FILESDIR}/${P}-glib_dep.patch"
>>>>> epatch "${FILESDIR}/${P}-ocfs2.patch"
>>>>> epatch "${FILESDIR}/${P}-use_disk_group.patch"
>>>>> epatch "${FILESDIR}/${P}-pagesize.patch"
>>>>
>>>> This would be another good candidate for using epatch's bulk patching,
>>>> particularly if you moved the last group of patches into the PV
>>>> directory.
>>>
>>> dev-zero?
>> Nope. The stuff in ${PV} are the patches upstream has on their servers,
>> while the others are mostly Gentoo-specific or something else. So I want
>> them to be separated.
>> And I don't see any reason to start renaming now.
> 
> Still no good reason not to just call epatch once:
> 
>      epatch \
>  list \
>  of \
>  patches \
>  here

Go ahead if you have enough spare time to handle this cosmetic stuff because I 
don't.

Cheers,
Tiziano

-- 
Tiziano Müller
Gentoo Linux Developer
Areas of responsibility: Samba, PostgreSQL, cpp, Python
E-Mail     : dev-zero@gentoo.org
GnuPG FP   : F327 283A E769 2E36 18D5  4DE2 1B05 6A63 AE9C 1E30

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]