From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IgEMK-0005n3-CL for garchives@archives.gentoo.org; Fri, 12 Oct 2007 06:50:56 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9C6eHmP026357; Fri, 12 Oct 2007 06:40:17 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9C6cI9R023765 for ; Fri, 12 Oct 2007 06:38:18 GMT Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id E121E6573E for ; Fri, 12 Oct 2007 06:38:17 +0000 (UTC) Date: Thu, 11 Oct 2007 23:38:16 -0700 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnatbuild.eclass Message-ID: <20071012063816.GH23990@supernova> References: <20071010181956.GA19824@supernova> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 3da14ec9-f263-41e6-b593-42ae904f928b X-Archives-Hash: 59633c96c19f227d12238fa102cf7db1 On 07:28 Fri 12 Oct , Steve Long wrote: > Donnie Berkholz wrote: > > > On 18:17 Wed 10 Oct , George Shapovalov (george) wrote: > >> george 07/10/10 18:17:58 > >> > >> Modified: gnatbuild.eclass > >> > >> Log: fixed src_install issue, no longer relies on portage leaking > >> env vars between functions > > > > It's really sad that you have to add this workaround. > > > If it's an env var that needs to be set in different phases, it doesn't > sound so bad to me? export or setting vars in the global ebuild scope is > fine imo. Portage is supposed to preserve the environment across functions. This workaround is added because that seems to break on a regular basis. Thanks, Donnie -- gentoo-dev@gentoo.org mailing list