public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnatbuild.eclass
       [not found] <E1Ifg86-0000SO-TD@stork.gentoo.org>
@ 2007-10-10 18:19 ` Donnie Berkholz
  2007-10-12  6:28   ` Steve Long
  0 siblings, 1 reply; 3+ messages in thread
From: Donnie Berkholz @ 2007-10-10 18:19 UTC (permalink / raw
  To: gentoo-dev, george

On 18:17 Wed 10 Oct     , George Shapovalov (george) wrote:
> george      07/10/10 18:17:58
> 
>   Modified: gnatbuild.eclass
>
>   Log: fixed src_install issue, no longer relies on portage leaking 
>   env vars between functions

It's really sad that you have to add this workaround.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gentoo-dev]  Re: [gentoo-commits] gentoo-x86 commit in eclass: gnatbuild.eclass
  2007-10-10 18:19 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnatbuild.eclass Donnie Berkholz
@ 2007-10-12  6:28   ` Steve Long
  2007-10-12  6:38     ` Donnie Berkholz
  0 siblings, 1 reply; 3+ messages in thread
From: Steve Long @ 2007-10-12  6:28 UTC (permalink / raw
  To: gentoo-dev

Donnie Berkholz wrote:

> On 18:17 Wed 10 Oct     , George Shapovalov (george) wrote:
>> george      07/10/10 18:17:58
>> 
>>   Modified: gnatbuild.eclass
>>
>>   Log: fixed src_install issue, no longer relies on portage leaking
>>   env vars between functions
> 
> It's really sad that you have to add this workaround.
> 
If it's an env var that needs to be set in different phases, it doesn't
sound so bad to me? export or setting vars in the global ebuild scope is
fine imo.


-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev]  Re: [gentoo-commits] gentoo-x86 commit in eclass: gnatbuild.eclass
  2007-10-12  6:28   ` Steve Long
@ 2007-10-12  6:38     ` Donnie Berkholz
  0 siblings, 0 replies; 3+ messages in thread
From: Donnie Berkholz @ 2007-10-12  6:38 UTC (permalink / raw
  To: gentoo-dev

On 07:28 Fri 12 Oct     , Steve Long wrote:
> Donnie Berkholz wrote:
> 
> > On 18:17 Wed 10 Oct     , George Shapovalov (george) wrote:
> >> george      07/10/10 18:17:58
> >> 
> >>   Modified: gnatbuild.eclass
> >>
> >>   Log: fixed src_install issue, no longer relies on portage leaking
> >>   env vars between functions
> > 
> > It's really sad that you have to add this workaround.
> > 
> If it's an env var that needs to be set in different phases, it doesn't
> sound so bad to me? export or setting vars in the global ebuild scope is
> fine imo.

Portage is supposed to preserve the environment across functions. This 
workaround is added because that seems to break on a regular basis.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-10-12  6:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Ifg86-0000SO-TD@stork.gentoo.org>
2007-10-10 18:19 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnatbuild.eclass Donnie Berkholz
2007-10-12  6:28   ` Steve Long
2007-10-12  6:38     ` Donnie Berkholz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox