From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-27078-garchives=archives.gentoo.org@gentoo.org>)
	id 1IgEHR-0005dU-RS
	for garchives@archives.gentoo.org; Fri, 12 Oct 2007 06:45:54 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
	by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9C6ZCF5022296;
	Fri, 12 Oct 2007 06:35:12 GMT
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9C6XGDS019990
	for <gentoo-dev@lists.gentoo.org>; Fri, 12 Oct 2007 06:33:16 GMT
Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id 2900D6575E;
	Fri, 12 Oct 2007 06:33:11 +0000 (UTC)
Date: Thu, 11 Oct 2007 23:33:09 -0700
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, zzam@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/lirc: ChangeLog
	lirc-0.8.2-r2.ebuild
Message-ID: <20071012063309.GG23990@supernova>
References: <E1Ig3os-0006Db-P9@stork.gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1Ig3os-0006Db-P9@stork.gentoo.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Archives-Salt: 3f3e6532-b301-4f85-bd08-0db423de8469
X-Archives-Hash: afaf0c1332498880b96837fa0abd9c4b

On 19:35 Thu 11 Oct     , Matthias Schwarzott (zzam) wrote:
> 1.1                  app-misc/lirc/lirc-0.8.2-r2.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/lirc/lirc-0.8.2-r2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-misc/lirc/lirc-0.8.2-r2.ebuild?rev=1.1&content-type=text/plain

> add_device() {
> 	((lirc_device_count++))

[skip lots of code]

> 	lirc_driver_count=0

"driver" != "device"

Might be useful to initialize it in add_device() if it's unset, so code 
being this far apart won't get out of sync.

> 	make DESTDIR="${D}" install || die "make install failed"

If emake doesn't work, please add a comment to that effect.

> 	newinitd ${FILESDIR}/lircd lircd
> 	newinitd ${FILESDIR}/lircmd lircmd
> 	newconfd ${FILESDIR}/lircd.conf lircd
> 
> 	insinto /etc/modules.d/
> 	newins ${FILESDIR}/modulesd.lirc lirc
> 
> 	newinitd ${FILESDIR}/irexec-initd irexec
> 	newconfd ${FILESDIR}/irexec-confd irexec

Quoting.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list