[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vlc: ChangeLog vlc-0.9.0_alpha20071009.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vlc: ChangeLog vlc-0.9.0_alpha20071009.ebuild

[Donnie Berkholz]

On 22:23 Tue 09 Oct     , Alexis Ballier (aballier) wrote:
> 1.1                  media-video/vlc/vlc-0.9.0_alpha20071009.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vlc/vlc-0.9.0_alpha20071009.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vlc/vlc-0.9.0_alpha20071009.ebuild?rev=1.1&content-type=text/plain

> IUSE="a52 3dfx debug altivec httpd vlm gnutls live v4l v4l2 cdda ogg matroska
> dvb dvd vcd vcdx dts flac mpeg vorbis theora X opengl truetype svg fbcon svga
> oss aalib ggi libcaca esd arts alsa wxwindows ncurses xosd lirc stream
> mp3 xv bidi sdl sdl-image png xml samba daap mod speex shout rtsp
> win32codecs skins hal avahi xinerama cddb directfb upnp nsplugin seamonkey
> optimisememory libnotify jack musepack x264 dc1394 lua gnome pvr taglib
> musicbrainz dbus libgcrypt id3tag cdio ffmpeg twolame"
> 
> RDEPEND="
> 		ffmpeg? ( >=media-video/ffmpeg-0.4.9_p20050226-r1 )
> 		cdda? ( >=dev-libs/libcdio-0.72
> 			cddb? ( >=media-libs/libcddb-1.2.0 ) )
> 		live? ( >=media-plugins/live-2007.02.20 )
> 		dvd? (	media-libs/libdvdread
> 				media-libs/libdvdcss
> 				>=media-libs/libdvdnav-0.1.9
> 				media-libs/libdvdplay )
> 		esd? ( media-sound/esound )
> 		ogg? ( media-libs/libogg )
> 		matroska? (
> 			>=dev-libs/libebml-0.7.6
> 			>=media-libs/libmatroska-0.8.0 )
> 		mp3? ( media-libs/libmad )
> 		a52? ( >=media-libs/a52dec-0.7.4-r3 )
> 		dts? ( media-libs/libdca )
> 		flac? ( media-libs/libogg
> 			>=media-libs/flac-1.1.2 )
> 		mpeg? ( >=media-libs/libmpeg2-0.3.2 )
> 		vorbis? ( media-libs/libvorbis )
> 		theora? ( media-libs/libtheora )
> 		truetype? ( media-libs/freetype
> 			media-fonts/ttf-bitstream-vera )

[crop another 30 or so]

Both the IUSE list and this dep list would be vastly easier to parse if 
they were ordered alphabetically.

> 	if use nsplugin; then
> 		if use seamonkey; then
> 			XPIDL=/usr/lib/seamonkey
> 			MOZILLA_CONFIG=/usr/lib/seamonkey/seamonkey-config
> 		else
> 			XPIDL=/usr/lib/mozilla-firefox
> 			MOZILLA_CONFIG=/usr/lib/mozilla-firefox/firefox-config
> 		fi
> 	fi

Should this be get_libdir() ?

> 
> 	econf \
> 		$(use_enable altivec) \
> 		$(use_enable stream sout) \
> 		$(use_enable httpd) \
> 		$(use_enable gnutls) \
> 		$(use_enable v4l) \
> 		$(use_enable v4l2) \
> 		$(use_enable cdda) $(use_enable cdda cddax)\
> 		$(use_enable cddb libcddb) \

[crop another 30 or so]

Another place where ordering would help.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vlc: ChangeLog vlc-0.9.0_alpha20071009.ebuild

[Alexis Ballier]

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Tue, 9 Oct 2007 16:28:23 -0700
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> > 	if use nsplugin; then
> > 		if use seamonkey; then
> > 			XPIDL=/usr/lib/seamonkey
> > 			MOZILLA_CONFIG=/usr/lib/seamonkey/seamonkey-config
> > 		else
> > 			XPIDL=/usr/lib/mozilla-firefox
> > 			MOZILLA_CONFIG=/usr/lib/mozilla-firefox/firefox-config
> > 		fi
> > 	fi
> 
> Should this be get_libdir() ?

should be more reliable indeed
it's used only to teach the build system where to find mozilla's stuff,
so as of now it shouldnt hurt, but I switched to get_libdir anyway.

> > 
> > 	econf \
> > 		$(use_enable altivec) \
> > 		$(use_enable stream sout) \
> > 		$(use_enable httpd) \
> > 		$(use_enable gnutls) \
> > 		$(use_enable v4l) \
> > 		$(use_enable v4l2) \
> > 		$(use_enable cdda) $(use_enable cdda cddax)\
> > 		$(use_enable cddb libcddb) \
> 
> [crop another 30 or so]
> 
> Another place where ordering would help.

good idea, thanks; it's a bit difficult to read as of now :/

Alexis.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]