public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alexis Ballier <aballier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vlc: ChangeLog vlc-0.9.0_alpha20071009.ebuild
Date: Wed, 10 Oct 2007 11:48:25 +0200	[thread overview]
Message-ID: <20071010114825.45ea7598@toz.strangled.net> (raw)
In-Reply-To: <20071009232823.GG962@supernova>

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Tue, 9 Oct 2007 16:28:23 -0700
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> > 	if use nsplugin; then
> > 		if use seamonkey; then
> > 			XPIDL=/usr/lib/seamonkey
> > 			MOZILLA_CONFIG=/usr/lib/seamonkey/seamonkey-config
> > 		else
> > 			XPIDL=/usr/lib/mozilla-firefox
> > 			MOZILLA_CONFIG=/usr/lib/mozilla-firefox/firefox-config
> > 		fi
> > 	fi
> 
> Should this be get_libdir() ?

should be more reliable indeed
it's used only to teach the build system where to find mozilla's stuff,
so as of now it shouldnt hurt, but I switched to get_libdir anyway.

> > 
> > 	econf \
> > 		$(use_enable altivec) \
> > 		$(use_enable stream sout) \
> > 		$(use_enable httpd) \
> > 		$(use_enable gnutls) \
> > 		$(use_enable v4l) \
> > 		$(use_enable v4l2) \
> > 		$(use_enable cdda) $(use_enable cdda cddax)\
> > 		$(use_enable cddb libcddb) \
> 
> [crop another 30 or so]
> 
> Another place where ordering would help.

good idea, thanks; it's a bit difficult to read as of now :/

Alexis.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2007-10-10 10:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1IfNUY-00034W-9d@stork.gentoo.org>
2007-10-09 23:28 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vlc: ChangeLog vlc-0.9.0_alpha20071009.ebuild Donnie Berkholz
2007-10-10  9:48   ` Alexis Ballier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071010114825.45ea7598@toz.strangled.net \
    --to=aballier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox