* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/tcpdump: ChangeLog tcpdump-3.9.8.ebuild
[not found] <E1IfJRE-0006y8-J2@stork.gentoo.org>
@ 2007-10-09 19:44 ` Donnie Berkholz
0 siblings, 0 replies; only message in thread
From: Donnie Berkholz @ 2007-10-09 19:44 UTC (permalink / raw
To: gentoo-dev, jokey
On 18:04 Tue 09 Oct , Markus Ullmann (jokey) wrote:
> 1.1 net-analyzer/tcpdump/tcpdump-3.9.8.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/tcpdump/tcpdump-3.9.8.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/tcpdump/tcpdump-3.9.8.ebuild?rev=1.1&content-type=text/plain
> src_compile() {
> # tcpdump needs some optymalization. see bug #108391
> ( ! is-flag -O? || is-flag -O0 ) && append-flags -O
You don't need a subshell here. If you feel that it improves
readability, use a code block instead.
> # Fix wrt bug #48747
> if [[ $(gcc-major-version) -gt 3 ]] || \
> [[ $(gcc-major-version) -eq 3 && $(gcc-minor-version) -ge 4 ]]
> then
> filter-flags -funit-at-a-time
> append-flags -fno-unit-at-a-time
> fi
This kind of stuff might be worth verifying whether it's still needed on
every bump. The last comment on the bug refers to gcc 4.0.*.
> make CCOPT="$CFLAGS" || die "make failed"
If emake doesn't work, please add a comment to that effect.
Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-10-09 19:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1IfJRE-0006y8-J2@stork.gentoo.org>
2007-10-09 19:44 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/tcpdump: ChangeLog tcpdump-3.9.8.ebuild Donnie Berkholz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox