From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IfDHi-0000qO-L3 for garchives@archives.gentoo.org; Tue, 09 Oct 2007 11:29:59 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l99BJSis017605; Tue, 9 Oct 2007 11:19:28 GMT Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l99BHUbt015020 for ; Tue, 9 Oct 2007 11:17:30 GMT Received: from smtp1-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp1-g19.free.fr (Postfix) with ESMTP id 264921AB2D4 for ; Tue, 9 Oct 2007 13:17:30 +0200 (CEST) Received: from toz.strangled.net (toz.strangled.net [82.232.126.136]) by smtp1-g19.free.fr (Postfix) with ESMTP id B325F1AB2B1 for ; Tue, 9 Oct 2007 13:17:29 +0200 (CEST) Date: Tue, 9 Oct 2007 13:17:46 +0200 From: Alexis Ballier To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Modular texlive eclasses up for review Message-ID: <20071009131746.4fcfba57@toz.strangled.net> In-Reply-To: <1191914011.2619.7.camel@uberpc.marples.name> References: <20071008234731.721a24e5@toz.strangled.net> <20071009010317.3515901b@toz.strangled.net> <1191914011.2619.7.camel@uberpc.marples.name> Organization: Gentoo X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.0; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/BCAbZRcxnBns9LsgpCjrRzC"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: 40e477b9-a0e8-4ee4-933f-a6d84eab03bf X-Archives-Hash: 8bf022b7ec197cd13a75e4edd1bed62a --Sig_/BCAbZRcxnBns9LsgpCjrRzC Content-Type: multipart/mixed; boundary="MP_/bs2dAyH4VrOFb3nKtKsPsVH" --MP_/bs2dAyH4VrOFb3nKtKsPsVH Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tue, 09 Oct 2007 08:13:31 +0100 Roy Marples wrote: > grep '^!' "${i}" | tr ' ' '=3D' |sort|uniq >> "${T}/jobs" > Could be done with a 1 sed and 1 sort call, but whatever floats your > boat. well as this is very inspired from texlive install-pkg.sh script, I'd prefer not differing that much. > if [ "${f/config/}" !=3D "${f}" ] > Should be > if [ "${f#*config*}" !=3D "${f}" ] changed that one, the "semantics" looks better indeed; what is wanted here is to exclude $f containing "config". Am I missing something when I understand it as the exact same thing but more readable ? > return $([ -f "${mark}" ]) > Could be written as > [ -f "${mark}" ] thanks, too much influence from other programming languages... Attached try3, with some more comments on the functions of texlive-module.eclass. Alexis. --MP_/bs2dAyH4VrOFb3nKtKsPsVH Content-Type: application/octet-stream; name=texlive-module.eclass Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=texlive-module.eclass IyBDb3B5cmlnaHQgMTk5OS0yMDA0IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCiMKIyBPcmlnaW5hbCBBdXRob3I6IEFsZXhpcyBCYWxsaWVyIDxhYmFsbGllckBnZW50 b28ub3JnPgojIFB1cnBvc2U6IFByb3ZpZGUgZ2VuZXJpYyBpbnN0YWxsIGZ1bmN0aW9ucyBzbyB0 aGF0IG1vZHVsYXIgdGV4bGl2ZSdzIHRleG1mIGVidWlsZHMgd2lsbAojIG9ubHkgaGF2ZSB0byBp bmhlcml0IHRoaXMgZWNsYXNzLgojIEVidWlsZHMgaGF2ZSB0byBwcm92aWRlIFRFWExJVkVfTU9E VUxFX0NPTlRFTlRTIHZhcmlhYmxlIHRoYXQgY29udGFpbnMgdGhlIGxpc3QKIyBvZiBwYWNrYWdl cyB0aGF0IGl0IHdpbGwgaW5zdGFsbC4KIyBURVhMSVZFX01PRFVMRV9DT05URU5UUyB3aWxsIGJl IGV4cGFuZGVkIHRvIFNSQ19VUkkgOiAKIwlmb28gLT4gdGV4bGl2ZS1tb2R1bGUtZm9vLSR7UFZ9 LnppcAojIFdoYXQgaXMgYXNzdW1lZCBpcyB0aGF0IGl0IHVucGFja3MgdGV4bWYgYW5kIHRleG1m LWRpc3QgZGlyZWN0b3JpZXMgdG8KIyAke1dPUktESVJ9LgojCgppbmhlcml0IHRleGxpdmUtY29t bW9uCgpIT01FUEFHRT0iaHR0cDovL3d3dy50dWcub3JnL3RleGxpdmUvIgoKZm9yIGkgaW4gJHtU RVhMSVZFX01PRFVMRV9DT05URU5UU307IGRvCglTUkNfVVJJPSIke1NSQ19VUkl9IG1pcnJvcjov L2dlbnRvby90ZXhsaXZlLW1vZHVsZS0ke2l9LSR7UFZ9LnppcCIKZG9uZQoKQ09NTU9OX0RFUEVO RD0iPj1hcHAtdGV4dC90ZXhsaXZlLWNvcmUtJHtQVn0KCSR7VEVYTElWRV9NT0RVTEVTX0RFUFN9 IgoKREVQRU5EPSIke0NPTU1PTl9ERVBFTkR9CglhcHAtYXJjaC91bnppcCIKClJERVBFTkQ9IiR7 Q09NTU9OX0RFUEVORH0iCgpJVVNFPSJkb2MiCgpTPSIke1dPUktESVJ9IgoKIyBzcmNfY29tcGls ZSwgZXhwb3J0ZWQgZnVuY3Rpb246CiMgV2lsbCBsb29rIGZvciBmb3JtYXQuZm9vLmNuZiBhbmQg YnVpbGQgZm9vIGZvcm1hdCBmaWxlcyB1c2luZyBmbXR1dGlsCiMgKHByb3ZpZGVkIGJ5IHRleGxp dmUtY29yZSkuIFRoZSBjb21waWxlZCBmb3JtYXQgZmlsZXMgd2lsbCBiZSBzZW50IHRvCiMgdGV4 bWYtdmFyL3dlYjJjLCBsaWtlIGZtdHV0aWwgZGVmYXVsdHMgdG8gYnV0IHdpdGggc29tZSB0cmlj ayB0byBzdGF5IGluIHRoZQojIHNhbmRib3gKIyBUaGUgbmV4dCBzdGVwIGlzIHRvIGdlbmVyYXRl IGNvbmZpZyBmaWxlcyB0aGF0IGFyZSB0byBiZSBpbnN0YWxsZWQgaW4KIyAvZXRjL3RleG1mOyB0 ZXhtZi11cGRhdGUgc2NyaXB0IHdpbGwgdGFrZSBjYXJlIG9mIG1lcmdpbmcgdGhlIGRpZmZlcmVu dCBjb25maWcKIyBmaWxlcyBmb3IgZGlmZmVyZW50IHBhY2thZ2VzIGluIGEgc2luZ2xlIG9uZSB1 c2VkIGJ5IHRoZSB3aG9sZSB0ZXggaW5zdGFsbGF0aW9uLgoKdGV4bGl2ZS1tb2R1bGVfc3JjX2Nv bXBpbGUoKSB7CgkjIEJ1aWxkIGZvcm1hdCBmaWxlcwoJZm9yIGkgaW4gdGV4bWYvZm10dXRpbC9m b3JtYXQqLmNuZjsgZG8KCQlpZiBbIC1mICIke2l9IiBdOyB0aGVuCgkJCWVpbmZvICJCdWlsZGlu ZyBmb3JtYXQgJHtpfSIKCQkJVEVYTUZIT01FPSIke1N9L3RleG1mOiR7U30vdGV4bWYtZGlzdCJc CgkJCQlmbXR1dGlsIC0tY25mZmlsZSAiJHtpfSIgLS1mbXRkaXIgIiR7U30vdGV4bWYtdmFyL3dl YjJjIiAtLWFsbFwKCQkJCXx8IGRpZSAiZmFpbGVkIHRvIGJ1aWxkIGZvcm1hdCAke2l9IgoJCWZp Cglkb25lCgoJIyBHZW5lcmF0ZSBjb25maWcgZmlsZXMKCWZvciBpIGluICIke1N9Ii90ZXhtZi9s aXN0cy8qOwoJZG8KCQlncmVwICdeIScgIiR7aX0iIHwgdHIgJyAnICc9JyB8c29ydHx1bmlxID4+ ICIke1R9L2pvYnMiCglkb25lCgoJZm9yIGogaW4gJCg8IiR7VH0vam9icyIpOwoJZG8KCQljb21t YW5kPSQoZWNobyAke2p9IHwgc2VkICdzLy5cKC4qXCk9LiovXDEvJykKCQlwYXJhbWV0ZXI9JChl Y2hvICR7an0gfCBzZWQgJ3MvLio9XCguKlwpL1wxLycpCgkJY2FzZSAiJHtjb21tYW5kfSIgaW4K CQkJYWRkTWFwKQoJCQkJZWNobyAiTWFwICR7cGFyYW1ldGVyfSIgPj4gIiR7U30vJHtQTn0uY2Zn Ijs7CgkJCWFkZE1peGVkTWFwKQoJCQkJZWNobyAiTWl4ZWRNYXAgJHtwYXJhbWV0ZXJ9IiA+PiAi JHtTfS8ke1BOfS5jZmciOzsKCQkJYWRkRHZpcHNNYXApCgkJCQllY2hvICJwCSske3BhcmFtZXRl cn0iID4+ICIke1N9LyR7UE59LWNvbmZpZy5wcyI7OwoJCQlhZGREdmlwZGZtTWFwKQoJCQkJZWNo byAiZgkke3BhcmFtZXRlcn0iID4+ICIke1N9LyR7UE59LWNvbmZpZyI7OwoJCWVzYWMKCWRvbmUK fQoKIyBzcmNfaW5zdGFsbCwgZXhwb3J0ZWQgZnVuY3Rpb246CiMgSW5zdGFsbCB0ZXhtZiBhbmQg Y29uZmlnIGZpbGVzIHRvIHRoZSBzeXN0ZW0KCnRleGxpdmUtbW9kdWxlX3NyY19pbnN0YWxsKCkg ewoJaW5zaW50byAvdXNyL3NoYXJlCglbIC1kIHRleG1mIF0gJiYgZG9pbnMgLXIgdGV4bWYKCVsg LWQgdGV4bWYtZGlzdCBdICYmIGRvaW5zIC1yIHRleG1mLWRpc3QKCVsgLWQgdGV4bWYtdmFyIF0g JiYgZG9pbnMgLXIgdGV4bWYtdmFyCgl1c2UgZG9jICYmIFsgLWQgdGV4bWYtZG9jIF0gJiYgZG9p bnMgLXIgdGV4bWYtZG9jCgoJaW5zaW50byAvZXRjL3RleG1mL3VwZG1hcC5kCglbIC1mICIke1N9 LyR7UE59LmNmZyIgXSAmJiBkb2lucyAiJHtTfS8ke1BOfS5jZmciCglpbnNpbnRvIC9ldGMvdGV4 bWYvZHZpcHMvY29uZmlnCglbIC1mICIke1N9LyR7UE59LWNvbmZpZy5wcyIgXSAmJiBkb2lucyAi JHtTfS8ke1BOfS1jb25maWcucHMiCglpbnNpbnRvIC9ldGMvdGV4bWYvZHZpcGRmbS9jb25maWcK CVsgLWYgIiR7U30vJHtQTn0tY29uZmlnIiBdICYmIGRvaW5zICIke1N9LyR7UE59LWNvbmZpZyIK Cgl0ZXhsaXZlLWNvbW1vbl9oYW5kbGVfY29uZmlnX2ZpbGVzCn0KCiMgcGtnX3Bvc3RpbnN0IGFu ZCBwa2dfcG9zdHJtLCBleHBvcnRlZCBmdW5jdGlvbnM6CiMgcnVuIHRleG1mLXVwZGF0ZSB0byBl bnN1cmUgdGhlIHRleCBpbnN0YWxsYXRpb24gaXMgY29uc2lzdGVudCB3aXRoIHRoZQojIGluc3Rh bGxlZCB0ZXhtZiB0cmVlcy4KCnRleGxpdmUtbW9kdWxlX3BrZ19wb3N0aW5zdCgpIHsKCWlmIFsg IiRST09UIiA9ICIvIiBdIDsgdGhlbgoJCS91c3Ivc2Jpbi90ZXhtZi11cGRhdGUKCWZpCn0KCnRl eGxpdmUtbW9kdWxlX3BrZ19wb3N0cm0oKSB7CglpZiBbICIkUk9PVCIgPSAiLyIgXSA7IHRoZW4K CQkvdXNyL3NiaW4vdGV4bWYtdXBkYXRlCglmaQp9CgpFWFBPUlRfRlVOQ1RJT05TIHNyY19jb21w aWxlIHNyY19pbnN0YWxsIHBrZ19wb3N0aW5zdCBwa2dfcG9zdHJtCg== --MP_/bs2dAyH4VrOFb3nKtKsPsVH Content-Type: application/octet-stream; name=texlive-common.eclass Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=texlive-common.eclass IyBDb3B5cmlnaHQgMTk5OS0yMDA3IEdlbnRvbyBGb3VuZGF0aW9uCiMgRGlzdHJpYnV0ZWQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2MgojICRIZWFk ZXI6ICQKCiMKIyBPcmlnaW5hbCBBdXRob3I6IEFsZXhpcyBCYWxsaWVyIDxhYmFsbGllckBnZW50 b28ub3JnPgojIFB1cnBvc2U6IFByb3ZpZGUgdmFyaW91cyBmdW5jdGlvbnMgdXNlZCBieSBib3Ro IHRleGxpdmUtY29yZSBhbmQgdGV4bGl2ZQojIG1vZHVsZXMuCiMgTm90ZSB0aGF0IHRoaXMgZWNs YXNzICptdXN0KiBub3QgYXNzdW1lIHRoZSBwcmVzZW5jZSBvZiBhbnkgc3RhbmRhcmQgdGV4IHRv b2wKIwoKClRFWE1GX1BBVEg9L3Vzci9zaGFyZS90ZXhtZgpURVhNRl9ESVNUX1BBVEg9L3Vzci9z aGFyZS90ZXhtZi1kaXN0ClRFWE1GX1ZBUl9QQVRIPS91c3Ivc2hhcmUvdGV4bWYtdmFyCgojIEhh cyB0byBiZSBjYWxsZWQgaW4gc3JjX2luc3RhbGwgYWZ0ZXIgaGF2aW5nIGluc3RhbGxlZCB0aGUg ZmlsZXMgaW4gJHtEfQojIFRoaXMgZnVuY3Rpb24gd2lsbCBtb3ZlIHRoZSByZWxldmFudCBmaWxl cyB0byAvZXRjL3RleG1mIGFuZCBzeW1saW5nIHRoZW0KIyBmcm9tIHRoZWlyIG9yaWdpbmFsIGxv Y2F0aW9uLiBUaGlzIGlzIHRvIGFsbG93IGVhc3kgdXBkYXRlIG9mIHRleGxpdmUncwojIGNvbmZp Z3VyYXRpb24KCnRleGxpdmUtY29tbW9uX2hhbmRsZV9jb25maWdfZmlsZXMoKSB7CgkjIEhhbmRs ZSBjb25maWcgZmlsZXMgcHJvcGVybHkKCWNkICIke0R9JHtURVhNRl9QQVRIfSIKCWZvciBmIGlu ICQoZmluZCAuIC1uYW1lICcqLmNuZicgLW8gLW5hbWUgJyouY2ZnJyAtdHlwZSBmIHwgc2VkIC1l ICJzOlwuLzo6ZyIpIDsgZG8KCQlpZiBbICIke2YjKmNvbmZpZyp9IiAhPSAiJHtmfSIgXSA7IHRo ZW4KCQkJY29udGludWUKCQlmaQoJCWRvZGlyIC9ldGMvdGV4bWYvJChkaXJuYW1lICR7Zn0pLmQK CQltdiAiJHtEfS8ke1RFWE1GX1BBVEh9LyR7Zn0iICIke0R9L2V0Yy90ZXhtZi8kKGRpcm5hbWUg JHtmfSkuZCIgfHwgZGllICJtdiAke2Z9IGZhaWxlZC4iCgkJZG9zeW0gL2V0Yy90ZXhtZi8kKGRp cm5hbWUgJHtmfSkuZC8kKGJhc2VuYW1lICR7Zn0pICR7VEVYTUZfUEFUSH0vJHtmfQoJZG9uZQp9 CgoKIyBSZXR1cm4gaWYgYSBmaWxlIGlzIHByZXNlbnQgaW4gdGhlIHRleG1mIHRyZWUKIyBDYWxs IGl0IGZyb20gdGhlIGRpcmVjdG9yeSBjb250YWluaW5nIHRleG1mIGFuZCB0ZXhtZi1kaXN0Cgp0 ZXhsaXZlLWNvbW1vbl9pc19maWxlX3ByZXNlbnRfaW5fdGV4bWYoKSB7Cglsb2NhbCBtYXJrPSIk e1R9LyQxLmZvdW5kIgoJZmluZCB0ZXhtZiAtbmFtZSAkMSAtZXhlYyB0b3VjaCAiJHttYXJrfSIg XDsKCWZpbmQgdGV4bWYtZGlzdCAtbmFtZSAkMSAtZXhlYyB0b3VjaCAiJHttYXJrfSIgXDsKCVsg LWYgIiR7bWFya30iIF0KfQo= --MP_/bs2dAyH4VrOFb3nKtKsPsVH-- --Sig_/BCAbZRcxnBns9LsgpCjrRzC Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQFHC2NbvFcC4BYPU0oRAmGlAKCs3H1JtXjzRDYS7ZmStIRE+zqtHACcCzxO MVwZ0eRSno4eX5wtCprI81M= =qrfP -----END PGP SIGNATURE----- --Sig_/BCAbZRcxnBns9LsgpCjrRzC-- -- gentoo-dev@gentoo.org mailing list