public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild
       [not found] <E1If0f8-00081l-81@stork.gentoo.org>
@ 2007-10-09  4:21 ` Donnie Berkholz
  2007-10-09 12:56   ` Doug Goldstein
  0 siblings, 1 reply; 5+ messages in thread
From: Donnie Berkholz @ 2007-10-09  4:21 UTC (permalink / raw
  To: gentoo-dev, cardoe

On 22:01 Mon 08 Oct     , Doug Goldstein (cardoe) wrote:
> 1.1                  sys-fs/evms/evms-2.5.5-r8.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r8.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r8.ebuild?rev=1.1&content-type=text/plain

> 	epatch "${FILESDIR}/${PV}/md_super_fix.patch"
> 	epatch "${FILESDIR}/${PV}/ntfs_unmkfs.patch"
> 	epatch "${FILESDIR}/${PV}/raid5_degrade_fix_v2.patch"
> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix.patch"
> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix_2.patch"
> 	epatch "${FILESDIR}/${PV}/raid5_algorithm.patch"
> 	epatch "${FILESDIR}/${PV}/cli_reload_options.patch"
> 	epatch "${FILESDIR}/${PV}/cli_query_segfault.patch"
> 	epatch "${FILESDIR}/${PV}/get_geometry.patch"
> 	epatch "${FILESDIR}/${PV}/BaseName.patch"
> 	epatch "${FILESDIR}/${PV}/disk_cache.patch"
> 
> 	epatch "${FILESDIR}/${P}-as-needed.patch"
> 	epatch "${FILESDIR}/${P}-glib_dep.patch"
> 	epatch "${FILESDIR}/${P}-ocfs2.patch"
> 	epatch "${FILESDIR}/${P}-use_disk_group.patch"
> 	epatch "${FILESDIR}/${P}-pagesize.patch"

This would be another good candidate for using epatch's bulk patching, 
particularly if you moved the last group of patches into the PV 
directory.

> 	mv -f ${D}/$(get_libdir)/*.a "${D}/usr/$(get_libdir)"
> 		mv -f ${D}/sbin/evmsgui ${D}/usr/sbin

Quoting

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild
  2007-10-09  4:21 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild Donnie Berkholz
@ 2007-10-09 12:56   ` Doug Goldstein
  2007-10-11  9:13     ` Tiziano Müller
  0 siblings, 1 reply; 5+ messages in thread
From: Doug Goldstein @ 2007-10-09 12:56 UTC (permalink / raw
  To: Gentoo Dev, dev-zero

Donnie Berkholz wrote:
> On 22:01 Mon 08 Oct     , Doug Goldstein (cardoe) wrote:
>> 1.1                  sys-fs/evms/evms-2.5.5-r8.ebuild
>>
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r8.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r8.ebuild?rev=1.1&content-type=text/plain
> 
>> 	epatch "${FILESDIR}/${PV}/md_super_fix.patch"
>> 	epatch "${FILESDIR}/${PV}/ntfs_unmkfs.patch"
>> 	epatch "${FILESDIR}/${PV}/raid5_degrade_fix_v2.patch"
>> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix.patch"
>> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix_2.patch"
>> 	epatch "${FILESDIR}/${PV}/raid5_algorithm.patch"
>> 	epatch "${FILESDIR}/${PV}/cli_reload_options.patch"
>> 	epatch "${FILESDIR}/${PV}/cli_query_segfault.patch"
>> 	epatch "${FILESDIR}/${PV}/get_geometry.patch"
>> 	epatch "${FILESDIR}/${PV}/BaseName.patch"
>> 	epatch "${FILESDIR}/${PV}/disk_cache.patch"
>>
>> 	epatch "${FILESDIR}/${P}-as-needed.patch"
>> 	epatch "${FILESDIR}/${P}-glib_dep.patch"
>> 	epatch "${FILESDIR}/${P}-ocfs2.patch"
>> 	epatch "${FILESDIR}/${P}-use_disk_group.patch"
>> 	epatch "${FILESDIR}/${P}-pagesize.patch"
> 
> This would be another good candidate for using epatch's bulk patching, 
> particularly if you moved the last group of patches into the PV 
> directory.

dev-zero?

I merely fixed baselayout-2 issues and didn't change any functionality 
of the ebuild since I don't have an evms setup to test.

> 
>> 	mv -f ${D}/$(get_libdir)/*.a "${D}/usr/$(get_libdir)"
>> 		mv -f ${D}/sbin/evmsgui ${D}/usr/sbin
> 
> Quoting
> 
> Thanks,
> Donnie

Your a bit late. I fixed the quoting issues in the ebuild around 8pm EDT 
along with a few other issues. See the -r9 ebuild.

-- 
Doug Goldstein <cardoe@gentoo.org>
http://dev.gentoo.org/~cardoe/
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild
  2007-10-09 12:56   ` Doug Goldstein
@ 2007-10-11  9:13     ` Tiziano Müller
  2007-10-11  9:48       ` Donnie Berkholz
  2007-10-11 16:19       ` Michael Sterrett -Mr. Bones.-
  0 siblings, 2 replies; 5+ messages in thread
From: Tiziano Müller @ 2007-10-11  9:13 UTC (permalink / raw
  To: Doug Goldstein; +Cc: Gentoo Dev

[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]

Am Dienstag, 9. Oktober 2007 14.56:24 schrieb Doug Goldstein:
> Donnie Berkholz wrote:
> > On 22:01 Mon 08 Oct     , Doug Goldstein (cardoe) wrote:
> >> 1.1                  sys-fs/evms/evms-2.5.5-r8.ebuild
> >>
> >> file :
> >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
> >>8.ebuild?rev=1.1&view=markup plain:
> >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
> >>8.ebuild?rev=1.1&content-type=text/plain
> >>
> >> 	epatch "${FILESDIR}/${PV}/md_super_fix.patch"
> >> 	epatch "${FILESDIR}/${PV}/ntfs_unmkfs.patch"
> >> 	epatch "${FILESDIR}/${PV}/raid5_degrade_fix_v2.patch"
> >> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix.patch"
> >> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix_2.patch"
> >> 	epatch "${FILESDIR}/${PV}/raid5_algorithm.patch"
> >> 	epatch "${FILESDIR}/${PV}/cli_reload_options.patch"
> >> 	epatch "${FILESDIR}/${PV}/cli_query_segfault.patch"
> >> 	epatch "${FILESDIR}/${PV}/get_geometry.patch"
> >> 	epatch "${FILESDIR}/${PV}/BaseName.patch"
> >> 	epatch "${FILESDIR}/${PV}/disk_cache.patch"
> >>
> >> 	epatch "${FILESDIR}/${P}-as-needed.patch"
> >> 	epatch "${FILESDIR}/${P}-glib_dep.patch"
> >> 	epatch "${FILESDIR}/${P}-ocfs2.patch"
> >> 	epatch "${FILESDIR}/${P}-use_disk_group.patch"
> >> 	epatch "${FILESDIR}/${P}-pagesize.patch"
> >
> > This would be another good candidate for using epatch's bulk patching,
> > particularly if you moved the last group of patches into the PV
> > directory.
>
> dev-zero?
Nope. The stuff in ${PV} are the patches upstream has on their servers, while 
the others are mostly Gentoo-specific or something else. So I want them to be 
separated.
And I don't see any reason to start renaming now.

Cheers,
Tiziano

-- 
Tiziano Müller
Gentoo Linux Developer
Areas of responsibility: Samba, PostgreSQL, cpp, Python
E-Mail     : dev-zero@gentoo.org
GnuPG FP   : F327 283A E769 2E36 18D5  4DE2 1B05 6A63 AE9C 1E30

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild
  2007-10-11  9:13     ` Tiziano Müller
@ 2007-10-11  9:48       ` Donnie Berkholz
  2007-10-11 16:19       ` Michael Sterrett -Mr. Bones.-
  1 sibling, 0 replies; 5+ messages in thread
From: Donnie Berkholz @ 2007-10-11  9:48 UTC (permalink / raw
  To: gentoo-dev; +Cc: Doug Goldstein

On 11:13 Thu 11 Oct     , Tiziano Müller wrote:
> Am Dienstag, 9. Oktober 2007 14.56:24 schrieb Doug Goldstein:
> > Donnie Berkholz wrote:
> > > On 22:01 Mon 08 Oct     , Doug Goldstein (cardoe) wrote:
> > >> 1.1                  sys-fs/evms/evms-2.5.5-r8.ebuild
> > >>
> > >> file :
> > >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
> > >>8.ebuild?rev=1.1&view=markup plain:
> > >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
> > >>8.ebuild?rev=1.1&content-type=text/plain
> > >>
> > >> 	epatch "${FILESDIR}/${PV}/md_super_fix.patch"
> > >> 	epatch "${FILESDIR}/${PV}/ntfs_unmkfs.patch"
> > >> 	epatch "${FILESDIR}/${PV}/raid5_degrade_fix_v2.patch"
> > >> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix.patch"
> > >> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix_2.patch"
> > >> 	epatch "${FILESDIR}/${PV}/raid5_algorithm.patch"
> > >> 	epatch "${FILESDIR}/${PV}/cli_reload_options.patch"
> > >> 	epatch "${FILESDIR}/${PV}/cli_query_segfault.patch"
> > >> 	epatch "${FILESDIR}/${PV}/get_geometry.patch"
> > >> 	epatch "${FILESDIR}/${PV}/BaseName.patch"
> > >> 	epatch "${FILESDIR}/${PV}/disk_cache.patch"
> > >>
> > >> 	epatch "${FILESDIR}/${P}-as-needed.patch"
> > >> 	epatch "${FILESDIR}/${P}-glib_dep.patch"
> > >> 	epatch "${FILESDIR}/${P}-ocfs2.patch"
> > >> 	epatch "${FILESDIR}/${P}-use_disk_group.patch"
> > >> 	epatch "${FILESDIR}/${P}-pagesize.patch"
> > >
> > > This would be another good candidate for using epatch's bulk patching,
> > > particularly if you moved the last group of patches into the PV
> > > directory.
> >
> > dev-zero?
> Nope. The stuff in ${PV} are the patches upstream has on their servers, while 
> the others are mostly Gentoo-specific or something else. So I want them to be 
> separated.
> And I don't see any reason to start renaming now.

Oh, I would've expected upstream patches to be in SRC_URI ...

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild
  2007-10-11  9:13     ` Tiziano Müller
  2007-10-11  9:48       ` Donnie Berkholz
@ 2007-10-11 16:19       ` Michael Sterrett -Mr. Bones.-
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Sterrett -Mr. Bones.- @ 2007-10-11 16:19 UTC (permalink / raw
  To: Gentoo Dev; +Cc: Doug Goldstein

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=utf-8; format=flowed, Size: 1983 bytes --]

On Thu, 11 Oct 2007, Tiziano Müller wrote:

> Am Dienstag, 9. Oktober 2007 14.56:24 schrieb Doug Goldstein:
>> Donnie Berkholz wrote:
>>> On 22:01 Mon 08 Oct     , Doug Goldstein (cardoe) wrote:
>>>> 1.1                  sys-fs/evms/evms-2.5.5-r8.ebuild
>>>>
>>>> file :
>>>> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
>>>> 8.ebuild?rev=1.1&view=markup plain:
>>>> http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/evms/evms-2.5.5-r
>>>> 8.ebuild?rev=1.1&content-type=text/plain
>>>>
>>>> 	epatch "${FILESDIR}/${PV}/md_super_fix.patch"
>>>> 	epatch "${FILESDIR}/${PV}/ntfs_unmkfs.patch"
>>>> 	epatch "${FILESDIR}/${PV}/raid5_degrade_fix_v2.patch"
>>>> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix.patch"
>>>> 	epatch "${FILESDIR}/${PV}/raid5_remove_spare_fix_2.patch"
>>>> 	epatch "${FILESDIR}/${PV}/raid5_algorithm.patch"
>>>> 	epatch "${FILESDIR}/${PV}/cli_reload_options.patch"
>>>> 	epatch "${FILESDIR}/${PV}/cli_query_segfault.patch"
>>>> 	epatch "${FILESDIR}/${PV}/get_geometry.patch"
>>>> 	epatch "${FILESDIR}/${PV}/BaseName.patch"
>>>> 	epatch "${FILESDIR}/${PV}/disk_cache.patch"
>>>>
>>>> 	epatch "${FILESDIR}/${P}-as-needed.patch"
>>>> 	epatch "${FILESDIR}/${P}-glib_dep.patch"
>>>> 	epatch "${FILESDIR}/${P}-ocfs2.patch"
>>>> 	epatch "${FILESDIR}/${P}-use_disk_group.patch"
>>>> 	epatch "${FILESDIR}/${P}-pagesize.patch"
>>>
>>> This would be another good candidate for using epatch's bulk patching,
>>> particularly if you moved the last group of patches into the PV
>>> directory.
>>
>> dev-zero?
> Nope. The stuff in ${PV} are the patches upstream has on their servers, while
> the others are mostly Gentoo-specific or something else. So I want them to be
> separated.
> And I don't see any reason to start renaming now.

Still no good reason not to just call epatch once:

     epatch \
 	list \
 	of \
 	patches \
 	here

Michael Sterrett
   -Mr. Bones.-
mr_bones_@gentoo.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-10-11 16:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1If0f8-00081l-81@stork.gentoo.org>
2007-10-09  4:21 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/evms: ChangeLog evms-2.5.5-r8.ebuild Donnie Berkholz
2007-10-09 12:56   ` Doug Goldstein
2007-10-11  9:13     ` Tiziano Müller
2007-10-11  9:48       ` Donnie Berkholz
2007-10-11 16:19       ` Michael Sterrett -Mr. Bones.-

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox