[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-plugins/vdr-extrecmenu: ChangeLog vdr-extrecmenu-1.0.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-plugins/vdr-extrecmenu: ChangeLog vdr-extrecmenu-1.0.ebuild

[Donnie Berkholz]

On 20:23 Sun 07 Oct     , Joerg Bornkessel (hd_brummy) wrote:
> 1.1                  media-plugins/vdr-extrecmenu/vdr-extrecmenu-1.0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-plugins/vdr-extrecmenu/vdr-extrecmenu-1.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-plugins/vdr-extrecmenu/vdr-extrecmenu-1.0.ebuild?rev=1.1&content-type=text/plain

> src_unpack() {
> 	vdr-plugin_src_unpack
> 
> 	if grep -q fskProtection /usr/include/vdr/timers.h; then
> 		sed -i "s:#WITHPINPLUGIN:WITHPINPLUGIN:" Makefile

This doesn't respect ROOT != / and it's also dependent on the build 
system.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-plugins/vdr-extrecmenu: ChangeLog vdr-extrecmenu-1.0.ebuild

[Matthias Schwarzott]

On Montag, 8. Oktober 2007, Donnie Berkholz wrote:
> On 20:23 Sun 07 Oct     , Joerg Bornkessel (hd_brummy) wrote:
> > 1.1                 
> > media-plugins/vdr-extrecmenu/vdr-extrecmenu-1.0.ebuild
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-plugins/vdr-extrecm
> >enu/vdr-extrecmenu-1.0.ebuild?rev=1.1&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-plugins/vdr-extrecm
> >enu/vdr-extrecmenu-1.0.ebuild?rev=1.1&content-type=text/plain
> >
> > src_unpack() {
> > 	vdr-plugin_src_unpack
> >
> > 	if grep -q fskProtection /usr/include/vdr/timers.h; then
> > 		sed -i "s:#WITHPINPLUGIN:WITHPINPLUGIN:" Makefile
>
> This doesn't respect ROOT != / and it's also dependent on the build
> system.
>
I guess ROOT-safeness here is irrelevant, as for vdr / vdr-plugin.eclass there 
is yet no good solution to use the headers from ${ROOT}/usr/include/vdr for 
compiling.


How can this be converted to respect ROOT ?

Most times the sources just do
#include <vdr/timers.h>

And this normally will find headers located under /usr/include.

Matthias

-- 
Matthias Schwarzott (zzam)
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-plugins/vdr-extrecmenu: ChangeLog vdr-extrecmenu-1.0.ebuild

[Piotr Jaroszyński]

On Monday 08 of October 2007 11:22:42 Matthias Schwarzott wrote:
> On Montag, 8. Oktober 2007, Donnie Berkholz wrote:
> > On 20:23 Sun 07 Oct     , Joerg Bornkessel (hd_brummy) wrote:
> > This doesn't respect ROOT != / and it's also dependent on the build
> > system.
>
> I guess ROOT-safeness here is irrelevant, as for vdr / vdr-plugin.eclass
> there is yet no good solution to use the headers from
> ${ROOT}/usr/include/vdr for compiling.
>
>
> How can this be converted to respect ROOT ?

$ROOT shouldn't be used in src_*

> Most times the sources just do
> #include <vdr/timers.h>
>
> And this normally will find headers located under /usr/include.

And that's the way to go. When you build with ROOT=/foo DEPEND is installed 
into / and only {R,P}DEPEND into /foo.

-- 
Best Regards,
Piotr Jaroszyński
--
gentoo-dev@gentoo.org mailing list