From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Ief3d-0004sv-0M for garchives@archives.gentoo.org; Sun, 07 Oct 2007 22:57:09 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l97MkIf8014084; Sun, 7 Oct 2007 22:46:18 GMT Received: from farragut.cafarelli.fr (farragut.cafarelli.fr [88.191.27.4]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l97MhkrB010585 for ; Sun, 7 Oct 2007 22:43:46 GMT Received: from enterprise.cafarelli.fr (voyageur.cafarelli.fr [82.67.159.41]) by farragut.cafarelli.fr (Postfix) with ESMTP id CB6A318BA1A for ; Mon, 8 Oct 2007 00:50:35 +0200 (CEST) Date: Mon, 8 Oct 2007 00:43:45 +0200 From: Bernard Cafarelli To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnustep-base.eclass Message-ID: <20071008004345.62ab5a23@enterprise.cafarelli.fr> In-Reply-To: <20071006000817.GQ29572@supernova> References: <20071005180356.GK29572@supernova> <20071006000817.GQ29572@supernova> Organization: Gentoo Foundation, Inc. X-Mailer: Claws Mail 3.0.1 (GTK+ 2.12.0; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 519712ad-c005-4d01-bfad-f0977f1e0b42 X-Archives-Hash: ab4a2b224f404d5deac65110ac0e9a4b Le Fri, 5 Oct 2007 17:08:17 -0700 Donnie Berkholz a =C3=A9crit: > On 17:31 Fri 05 Oct , Ryan Hill wrote: > > If there aren't any variables that you actually need expanded in the > > script (i didn't see any but could have easily missed it), just escape > > the termination marker, ie. > >=20 > > cat << \EOF > "${T}"/${cfile} > >=20 > > or > > cat << 'EOF' > "${T}"/${cfile} > >=20 > > This turns off parameter and arithmetic expansion and command > > substitution. >=20 > That is so cool. Just another reason I love this reviewing. Yes, thanks for the suggestion, this looks perfect! These lines originally had some ${GNUSTEP_...} variables in them, which required expansion in the ebuild, hence the backquotes forest... Now, however the only one here is ${P}, which will probably be left alone in its own echo command. I'll look into that soon. By the way, even if this probably won't be need in that case, what's the policy on adding files for eclasses, as uberlord suggested? The only subfolder in eclasses/ for now is ELT-patches, but maybe because for now no eclass needed that feature --=20 Bernard Cafarelli (Voyageur) NX and GNUstep Gentoo developer -- gentoo-dev@gentoo.org mailing list