Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gnustep-base.eclass

[Bernard Cafarelli <voyageur@gentoo.org>]

Le Fri, 5 Oct 2007 17:08:17 -0700
Donnie Berkholz <dberkholz@gentoo.org> a écrit:

> On 17:31 Fri 05 Oct     , Ryan Hill wrote:
> > If there aren't any variables that you actually need expanded in the
> > script (i didn't see any but could have easily missed it), just escape
> > the termination marker, ie.
> > 
> >     cat << \EOF > "${T}"/${cfile}
> > 
> > or
> >     cat << 'EOF' > "${T}"/${cfile}
> > 
> > This turns off parameter and arithmetic expansion and command
> > substitution.
> 
> That is so cool. Just another reason I love this reviewing.

Yes, thanks for the suggestion, this looks perfect!

These lines originally had some ${GNUSTEP_...} variables in them, which
required expansion in the ebuild, hence the backquotes forest...

Now, however the only one here is ${P}, which will probably be left
alone in its own echo command. I'll look into that soon.

By the way, even if this probably won't be need in that case, what's
the policy on adding files for eclasses, as uberlord suggested? The
only subfolder in eclasses/ for now is ELT-patches, but maybe because
for now no eclass needed that feature

-- 
Bernard Cafarelli (Voyageur)
NX and GNUstep Gentoo developer
--
gentoo-dev@gentoo.org mailing list