From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-26924-garchives=archives.gentoo.org@gentoo.org>)
	id 1IeS85-0000uy-Es
	for garchives@archives.gentoo.org; Sun, 07 Oct 2007 09:08:53 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
	by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l978vrkw010552;
	Sun, 7 Oct 2007 08:57:53 GMT
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l978rPH5001940
	for <gentoo-dev@lists.gentoo.org>; Sun, 7 Oct 2007 08:53:26 GMT
Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id ECA4165437;
	Sun,  7 Oct 2007 08:53:24 +0000 (UTC)
Date: Sun, 7 Oct 2007 01:53:23 -0700
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, markusle@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-lang/R: ChangeLog
	R-2.6.0.ebuild R-2.4.1.ebuild R-2.5.0.ebuild
Message-ID: <20071007085323.GF31103@supernova>
References: <E1IeAX2-0007JL-Dx@stork.gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1IeAX2-0007JL-Dx@stork.gentoo.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Archives-Salt: f4b4e6d9-3eae-4261-b52f-6af769be643a
X-Archives-Hash: 98e02d3b1eda0dad127af072dbdb6750

On 14:21 Sat 06 Oct     , Markus Dittrich (markusle) wrote:
> 1.1                  dev-lang/R/R-2.6.0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/R/R-2.6.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-lang/R/R-2.6.0.ebuild?rev=1.1&content-type=text/plain

> pkg_setup() {
> 	# Test for a 64 bit architecture - f2c won't work on 64 bit archs with R.
> 	# Thanks to vapier for providing the test.
> 	cd "${T}"
> 	echo 'int main(){}' > test.c
> 	$(tc-getCC) -c test.c -o test.o
> 	if file test.o | grep -qs 64-bit ; then
> 		einfo "64 bit architecture detected, using g77 or gfortran."

 ... or ifc?

> 		FORTRAN="gfortran g77 ifc"
> 	else
> 		FORTRAN="gfortran g77 f2c"

How come ifc isn't down here, too?

> 	# R-2.5.0 started to have issues with parallel make
> 	emake -j1 || die "emake failed"

Got an upstream bug filed?

> 	make \

If emake doesn't work, please add a comment to that effect.

> 		prefix=${D}/usr \
> 		mandir=${D}/usr/share/man \
> 		infodir=${D}/usr/share/info \
> 		libdir=${D}/usr/$(get_libdir) \
> 		rhome=${D}/usr/$(get_libdir)/R \

> 		-i ${D}/usr/$(get_libdir)/R/bin/R \
> 		-i ${D}/usr/$(get_libdir)/R/bin/R \
> 	sed -e "s:${D}::" -i ${D}/usr/$(get_libdir)/pkgconfig/libR.pc \
> 	cd ${D}/usr/bin/
> 		> ${D}/etc/env.d/99R
> 	cd ${S}

Quote variables that can have spaces in them: D, S, T, WORKDIR, 
FILESDIR, DESTDIR, ROOT.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list