public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in gnome-extra/gnome-power-manager: ChangeLog gnome-power-manager-2.20.0.ebuild
       [not found] <E1IckoG-0001VJ-AK@stork.gentoo.org>
@ 2007-10-03  5:58 ` Donnie Berkholz
  2007-10-03  6:07   ` Donnie Berkholz
  0 siblings, 1 reply; 2+ messages in thread
From: Donnie Berkholz @ 2007-10-03  5:58 UTC (permalink / raw
  To: gentoo-dev, compnerd

On 16:41 Tue 02 Oct     , Saleem Abdulrasool (compnerd) wrote:
> 1.1                  gnome-extra/gnome-power-manager/gnome-power-manager-2.20.0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/gnome-extra/gnome-power-manager/gnome-power-manager-2.20.0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/gnome-extra/gnome-power-manager/gnome-power-manager-2.20.0.ebuild?rev=1.1&content-type=text/plain

> 			${S}/docs/Makefile.in
> 		sed -i -e 's:@HAVE_DOCBOOK2MAN_TRUE@.*::' ${S}/man/Makefile.in

Quoting

> src_test() {
> 	Xmake check || die "Test phase failed"

Is Xmake/virtualx.eclass still needed?

> 	if [[ $(portageq has_version / 'sys-libs/pam') ]] ; then

You don't need to call portageq, you're already inside portage.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in gnome-extra/gnome-power-manager: ChangeLog gnome-power-manager-2.20.0.ebuild
  2007-10-03  5:58 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in gnome-extra/gnome-power-manager: ChangeLog gnome-power-manager-2.20.0.ebuild Donnie Berkholz
@ 2007-10-03  6:07   ` Donnie Berkholz
  0 siblings, 0 replies; 2+ messages in thread
From: Donnie Berkholz @ 2007-10-03  6:07 UTC (permalink / raw
  To: gentoo-dev, compnerd

On 22:58 Tue 02 Oct     , Donnie Berkholz wrote:
> On 16:41 Tue 02 Oct     , Saleem Abdulrasool (compnerd) wrote:
> > 	if [[ $(portageq has_version / 'sys-libs/pam') ]] ; then
> 
> You don't need to call portageq, you're already inside portage.

Oh yes, this also is broken for ROOT != /. Just wanted to make sure that 
didn't slip through when you change it.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-03  6:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1IckoG-0001VJ-AK@stork.gentoo.org>
2007-10-03  5:58 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in gnome-extra/gnome-power-manager: ChangeLog gnome-power-manager-2.20.0.ebuild Donnie Berkholz
2007-10-03  6:07   ` Donnie Berkholz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox