From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IcViG-00051g-4P for garchives@archives.gentoo.org; Tue, 02 Oct 2007 00:34:12 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l920OLPs004867; Tue, 2 Oct 2007 00:24:21 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l920MNCp002553 for ; Tue, 2 Oct 2007 00:22:23 GMT Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 98C1664F83 for ; Tue, 2 Oct 2007 00:22:22 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] RFC: sh versionator.eclass Date: Mon, 1 Oct 2007 20:22:21 -0400 User-Agent: KMail/1.9.7 References: <200710012259.40589.uberlord@gentoo.org> <20071001224136.GA9048@ferdyx.org> <200710012348.55548.uberlord@gentoo.org> In-Reply-To: <200710012348.55548.uberlord@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2227673.uThhp7xeIZ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200710012022.21957.vapier@gentoo.org> X-Archives-Salt: 540f534d-09fd-440d-a04a-e67c0ca259fc X-Archives-Hash: 0582597c0ad40b61b7b2a20330bc2f29 --nextPart2227673.uThhp7xeIZ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 01 October 2007, Roy Marples wrote: > On Monday 01 October 2007 23:41:36 Fernando J. Pereda wrote: > > I sure as hell am not going to proof read all that (mainly because I > > think not using bash features in an environment where bash is required > > is silly, instead of being an improvement) > > OK. Maybe I shouldn't have mentioned the "in sh" bit. > If I re-submit stuff and just claim better readability and less code you'= ll > read it then? "better readability" is a pretty subjective claim ... i'd say that changing= =20 things from doing a case match against proper character classes to doing a= =20 printf against arbitrary character ranges (which btw are not locale safe, s= o=20 i imagine you've introduced a regression there) is not "better". but i'm n= ot=20 the maintainer of said eclass. > > but I find interesting that > > you ripped Ciaran's copyright while leaving the "Prod ciaranm if you > > find something it can't handle" comment. > > I copied and pasted the comments for the most part. Sorry for leaving that > bit in. And I thought that the Gentoo Foundation had the copyright? it does. and if it doesnt, punt the file and rewrite it from scratch. =2Dmike --nextPart2227673.uThhp7xeIZ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iQIVAwUARwGPPUFjO5/oN/WBAQKynRAAzGWteD/2Nh24LDH9/YoBfacidGlGu2+M 1yHwrQ1lWpjejd2PLZP5T3ebjsffpY+ZJh10MNuCnoa/Owlgvf/75iKEFCCU8S4d h6TDKbcp7dHR4ro2CcidrtSw2Nr984+M63SozCEhlOud6yCyjd6L7OMNbbc3PXMA 0+QlafhpiJTdWXIC/9dEOHI5vOfRPFEzD8tqclddvrRVCjZ+nUU448I2IuOkPr1m CGJdu+kkkYPP+nzl+zgXCeYKfaDgqdA25ZOG3ZkPi+w3pTVlcvR5esfc9R7O1epW QXa2EjIUOfNZEox5UwOTjrmrnpDu3DRPjswCDT+NdCZPc3L4DHR3nsYj7Y9XpFJY Bnr8dRKulsPDlxZqpQOeE9+q6VcfpaunFoIQWMo1eTX9DG+NwHBarYmCjClwiY8F ZPRGoOy+LFxu/CLY1yuDwhDLevQ7j8bMha3yCba7X2jdk6aXWa8cwApIz8pQWYx2 50B3Lzu/k8sNcd/xxy7RWBUoccYVsjtwtRO6xrYNmO3ehDIx530xUEBPwco5zsm8 yaoaX05WP903FnjHNYP/rQ3hI3gRfRO8d9BVarZm07LdUwPY3dffHy7Y2j9Ri6XQ InSB1H8qVRhUFpp7+F+fOG+aoaCAZ+wqIrxt2RaOFGb6yudPxiBMd1vR2n/OtWys z3RAD8QYhRw= =22Mu -----END PGP SIGNATURE----- --nextPart2227673.uThhp7xeIZ-- -- gentoo-dev@gentoo.org mailing list