From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-26679-garchives=archives.gentoo.org@gentoo.org>)
	id 1Ic67y-00017n-9W
	for garchives@archives.gentoo.org; Sun, 30 Sep 2007 21:15:02 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
	by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l8UL5IoD028734;
	Sun, 30 Sep 2007 21:05:18 GMT
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l8UL3Gnq026360
	for <gentoo-dev@lists.gentoo.org>; Sun, 30 Sep 2007 21:03:17 GMT
Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id B321265990;
	Sun, 30 Sep 2007 21:03:16 +0000 (UTC)
Date: Sun, 30 Sep 2007 14:03:15 -0700
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, zzam@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vdr:
	ChangeLog vdr-1.4.7-r5.ebuild
Message-ID: <20070930210315.GJ28813@supernova>
References: <E1Iby5z-0001a9-S1@stork.gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1Iby5z-0001a9-S1@stork.gentoo.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Archives-Salt: 664a1b06-76fd-4a56-b6c6-1a4f2d4f5207
X-Archives-Hash: 21a1bae5c89f605e8a8c8a5f036625f9

On 12:40 Sun 30 Sep     , Matthias Schwarzott (zzam) wrote:
> 1.1                  media-video/vdr/vdr-1.4.7-r5.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vdr/vdr-1.4.7-r5.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vdr/vdr-1.4.7-r5.ebuild?rev=1.1&content-type=text/plain

> add_cap() {
> 	while [ "$1" ]; do
> 		CAPS="${CAPS}\n$1=1"
> 		shift
> 	done
> }
> 
> enable_patch() {
> 	local patch
> 	while [ "$1" ]; do
> 		patch="$1"
> 		echo "$patch = 1" >> Make.config
> 		shift
> 	done
> }

This is a really strange idiom. Why not do something like:

for arg in "$@"; do
	CAPS="${CAPS}\n${arg}=1"
done

for arg in "$@"; do
	echo "$arg = 1" >> Make.config
done

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list