public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vdr: ChangeLog vdr-1.4.7-r5.ebuild
       [not found] <E1Iby5z-0001a9-S1@stork.gentoo.org>
@ 2007-09-30 21:03 ` Donnie Berkholz
  0 siblings, 0 replies; only message in thread
From: Donnie Berkholz @ 2007-09-30 21:03 UTC (permalink / raw
  To: gentoo-dev, zzam

On 12:40 Sun 30 Sep     , Matthias Schwarzott (zzam) wrote:
> 1.1                  media-video/vdr/vdr-1.4.7-r5.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vdr/vdr-1.4.7-r5.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vdr/vdr-1.4.7-r5.ebuild?rev=1.1&content-type=text/plain

> add_cap() {
> 	while [ "$1" ]; do
> 		CAPS="${CAPS}\n$1=1"
> 		shift
> 	done
> }
> 
> enable_patch() {
> 	local patch
> 	while [ "$1" ]; do
> 		patch="$1"
> 		echo "$patch = 1" >> Make.config
> 		shift
> 	done
> }

This is a really strange idiom. Why not do something like:

for arg in "$@"; do
	CAPS="${CAPS}\n${arg}=1"
done

for arg in "$@"; do
	echo "$arg = 1" >> Make.config
done

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-09-30 21:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Iby5z-0001a9-S1@stork.gentoo.org>
2007-09-30 21:03 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vdr: ChangeLog vdr-1.4.7-r5.ebuild Donnie Berkholz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox