From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Ia6N0-0004HG-99 for garchives@archives.gentoo.org; Tue, 25 Sep 2007 09:06:18 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l8P8udRO029214; Tue, 25 Sep 2007 08:56:39 GMT Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l8P8slsk026918 for ; Tue, 25 Sep 2007 08:54:47 GMT Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id A0CAF223B96 for ; Tue, 25 Sep 2007 10:54:47 +0200 (CEST) Received: from gauss.x.fun (DSL01.83.171.181.197.ip-pool.NEFkom.net [83.171.181.197]) by mail.nefkom.net (Postfix) with ESMTP id 852C890232 for ; Tue, 25 Sep 2007 10:54:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by gauss.x.fun (Postfix) with ESMTP id A1FA05E9 for ; Tue, 25 Sep 2007 10:54:46 +0200 (CEST) From: Matthias Schwarzott To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild Date: Tue, 25 Sep 2007 10:54:43 +0200 User-Agent: KMail/1.9.7 References: <20070924200956.GS22279@supernova> In-Reply-To: <20070924200956.GS22279@supernova> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709251054.43817.zzam@gentoo.org> X-Archives-Salt: fa2f653e-1e99-4659-849f-2f066cb9b374 X-Archives-Hash: 9bebd623aa2ab8ed7fb8d29258a46c3f On Montag, 24. September 2007, Donnie Berkholz wrote: > On 19:59 Mon 24 Sep , Matthias Schwarzott (zzam) wrote: > > zzam 07/09/24 19:59:38 > > > > This ebuild has really inconsistent use of tests, quotes in tests, and > command substitutions. Being more consistent will increase readability > and decrease bugs due to differences between styles. For tests, pick a > style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice > because it generally doesn't require quotes, so the code looks a lot > cleaner. For command substitions, prefer $() over ``. > > > newins ${FILESDIR}/blacklist-110 blacklist > > doins ${FILESDIR}/pnp-aliases > > Quotes here. > > > emake \ > > EXTRAS="${extras}" \ > > libudevdir=${udev_helper_dir} \ > > CROSS_COMPILE=${mycross} \ > > OPTFLAGS="" \ > > ${myconf} || die > > > > emake \ > > DESTDIR="${D}" \ > > libudevdir=${udev_helper_dir} \ > > EXTRAS="${extras}" \ > > ${myconf} \ > > install || die > > Could use some die messages here. > > Thanks, > Donnie fixed, thanks Matthias -- Matthias Schwarzott (zzam) -- gentoo-dev@gentoo.org mailing list