From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IZude-0005QI-RS for garchives@archives.gentoo.org; Mon, 24 Sep 2007 20:34:43 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l8OKOPS0007044; Mon, 24 Sep 2007 20:24:25 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l8OKIxZF030557 for ; Mon, 24 Sep 2007 20:19:32 GMT Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id B57456594D; Mon, 24 Sep 2007 20:09:58 +0000 (UTC) Date: Mon, 24 Sep 2007 13:09:57 -0700 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org Cc: zzam@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild Message-ID: <20070924200956.GS22279@supernova> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 0cd72d26-d363-435a-9316-d8f350236944 X-Archives-Hash: 3499b7a6d110f42d44f276c0b16caafd On 19:59 Mon 24 Sep , Matthias Schwarzott (zzam) wrote: > zzam 07/09/24 19:59:38 > > Modified: ChangeLog > Added: udev-115-r6.ebuild > Log: > Simplified rules a bit. Let user configure max inode nr of /dev, solving bug #193586. > (Portage version: 2.1.3.9) > 1.1 sys-fs/udev/udev-115-r6.ebuild > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/udev/udev-115-r6.ebuild?rev=1.1&view=markup > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-fs/udev/udev-115-r6.ebuild?rev=1.1&content-type=text/plain > if [[ "${KV_MAJOR}" == 2 ]] && [[ "${KV_MINOR}" == 6 ]] && [[ "${KV_MICRO}" -ge 15 ]]; then > if [[ "$ok" = "0" ]]; then > if [ "${MD5}" != "644e3c77eb866dee4ff8dda2e95cd187" ] > if [[ -f "packages/40-${ARCH}.rules" ]]; then > if [ -h "${ROOT}/etc/hotplug.d/default/udev.hotplug" ] > if [ -h "${ROOT}/etc/hotplug.d/default/05-wait_for_sysfs.hotplug" ] > if [ -h "${ROOT}/etc/hotplug.d/default/10-udev.hotplug" ] > if [ -f "${ROOT}/etc/init.d/coldplug" ] > if [[ ${coldplug_stale} == "1" ]] ; then > if [[ -e "${ROOT}/etc/udev/rules.d/40-scsi-hotplug.rules" ]] > if [[ -d "${ROOT}"/lib/udev/devices ]]; then > if [[ -e "${ROOT}"/etc/udev/rules.d/95-net.rules ]]; then > if [[ -d "${ROOT}"/etc/dev.d ]]; then > if [[ -d "${ROOT}"/etc/dev.d ]]; then > [[ -f "${ROOT}"/etc/udev/rules.d/64-device-mapper.rules ]] && > if [[ "${ROOT}" == "/" ]] ; then > if [ -r /proc/1/root -a /proc/1/root/ -ef /proc/self/root/ ]; then > if [[ -n $(pidof udevd) ]] ; then > MD5=`md5sum < "${S}/etc/udev/rules.d/50-udev-default.rules"` This ebuild has really inconsistent use of tests, quotes in tests, and command substitutions. Being more consistent will increase readability and decrease bugs due to differences between styles. For tests, pick a style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice because it generally doesn't require quotes, so the code looks a lot cleaner. For command substitions, prefer $() over ``. > newins ${FILESDIR}/blacklist-110 blacklist > doins ${FILESDIR}/pnp-aliases Quotes here. > emake \ > EXTRAS="${extras}" \ > libudevdir=${udev_helper_dir} \ > CROSS_COMPILE=${mycross} \ > OPTFLAGS="" \ > ${myconf} || die > emake \ > DESTDIR="${D}" \ > libudevdir=${udev_helper_dir} \ > EXTRAS="${extras}" \ > ${myconf} \ > install || die Could use some die messages here. Thanks, Donnie -- gentoo-dev@gentoo.org mailing list