[gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

ive been sending private e-mails as i didnt want to make a lot of noise, but 
many of the comments i make i imagine would be applicable to a lot of 
people ... i also see others doing reviews and such

how do people feel about responses ?  keep them all on gentoo-dev or start a 
new list just for reviews ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Mike Doty]

Mike Frysinger wrote:
> ive been sending private e-mails as i didnt want to make a lot of noise, but 
> many of the comments i make i imagine would be applicable to a lot of 
> people ... i also see others doing reviews and such
> 
> how do people feel about responses ?  keep them all on gentoo-dev or start a 
> new list just for reviews ?
> -mike
I don't think we need yet another list, we have far too many as it is.  -dev is
for discussion, it should be here.

--taco
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Bo Ørsted Andresen]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

On Tuesday 18 September 2007 01:33:33 Mike Frysinger wrote:
> ive been sending private e-mails as i didnt want to make a lot of noise,
> but many of the comments i make i imagine would be applicable to a lot of
> people ... i also see others doing reviews and such
>
> how do people feel about responses ?  keep them all on gentoo-dev or start
> a new list just for reviews ?

You could use the gentoo-devhelp list which has been promised on bug #130886.

https://bugs.gentoo.org/show_bug.cgi?id=130886

-- 
Bo Andresen

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On Tue, Sep 18, 2007 at 01:38:15AM +0200, Bo ??rsted Andresen wrote:
> On Tuesday 18 September 2007 01:33:33 Mike Frysinger wrote:
> > ive been sending private e-mails as i didnt want to make a lot of noise,
> > but many of the comments i make i imagine would be applicable to a lot of
> > people ... i also see others doing reviews and such
> >
> > how do people feel about responses ?  keep them all on gentoo-dev or start
> > a new list just for reviews ?
> You could use the gentoo-devhelp list which has been promised on bug #130886.
> https://bugs.gentoo.org/show_bug.cgi?id=130886
antarus requested "-dev-help" before the -project and -dev-announce
lists were created, and was not impressed that it couldn't be exactly
-dev-help. 

Anyway, the stated goals for that list were to be a place for
communication between advanced users and developers to interact. Review
of commits would best belong on -dev, where a higher proportion of
developers would read the reviewing.

-- 
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85

[-- Attachment #2: Type: application/pgp-signature, Size: 321 bytes --]

[gentoo-dev] Re: commit reviewing ... new list or keep it on -dev ?

[Ryan Hill]

Mike Frysinger wrote:
> ive been sending private e-mails as i didnt want to make a lot of noise, but 
> many of the comments i make i imagine would be applicable to a lot of 
> people ... i also see others doing reviews and such
> 
> how do people feel about responses ?  keep them all on gentoo-dev or start a 
> new list just for reviews ?

I've found the private and public reviewing very helpful.  Unless someone has a
complaint I'd say keep them here, though if gentoo-dev-help ever does go
through I think that would be the best place to do it.

-- 
                  fonts / wxWindows / gcc-porting / treecleaners
  9B81 6C9F E791 83BB 3AB3  5B2D E625 A073 8379 37E8 (0x837937E8)

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Robert Buchholz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 18.09.2007 um 01:33 schrieb Mike Frysinger:

> ive been sending private e-mails as i didnt want to make a lot of  
> noise, but
> many of the comments i make i imagine would be applicable to a lot of
> people ... i also see others doing reviews and such

/me also likes reading them on this list.

If anyone wants to filter them, procmailing [gentoo-dev].*[gentoo- 
commits] will do.

Robert

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFG73cvyZx3L/ph1soRAidUAJ4hw+RE26wq1vaR5MHEaV2wdL9KjwCfeXzB
ldFjS6tBKxjBLEd8SJz68AE=
=Wpdu
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Lars Weiler]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

* Mike Frysinger <vapier@gentoo.org> [07/09/17 19:33 -0400]:
> how do people feel about responses ?  keep them all on gentoo-dev or start a 
> new list just for reviews ?

IMHO this list is a good place for the responses, so that
every dev can learn from them.  Don't keep them in private
only.  I can add an appropriate Reply-To in the
commit-messages, so that the replies show up here.

Thanks a lot for reviewing!

Regards, Lars

-- 
Lars Weiler  <pylon@gentoo.org>  +49-171-1963258
Instant Messaging     : pylon@jabber.ccc.de
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Wed, Sep 19, 2007 at 01:28:54AM +0200, Lars Weiler wrote:
> IMHO this list is a good place for the responses, so that
> every dev can learn from them.  Don't keep them in private
> only.  I can add an appropriate Reply-To in the
> commit-messages, so that the replies show up here.
Reply-To on gentoo-commits is already set to gentoo-dev@lists.g.o

-- 
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85

[-- Attachment #2: Type: application/pgp-signature, Size: 321 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Lars Weiler]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

* Robin H. Johnson <robbat2@gentoo.org> [07/09/18 17:23 -0700]:
> Reply-To on gentoo-commits is already set to gentoo-dev@lists.g.o

I guess this is set by the mailing-list-software?  That
collides with https://bugs.gentoo.org/193376.

Regards, Lars

-- 
Lars Weiler  <pylon@gentoo.org>  +49-171-1963258
Instant Messaging     : pylon@jabber.ccc.de
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Jeffrey Gardner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Lars Weiler wrote:
> * Robin H. Johnson <robbat2@gentoo.org> [07/09/18 17:23 -0700]:
>> Reply-To on gentoo-commits is already set to gentoo-dev@lists.g.o
> 
> I guess this is set by the mailing-list-software?  That
> collides with https://bugs.gentoo.org/193376.
> 
> Regards, Lars
> 

Please keep the commit reviews coming on gentoo-dev.

- --
Jeffrey Gardner
Gentoo Developer
Public PGP Key ID: 4A5D8F23
hkp://pgpkeys.mit.edu
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG99PSiR2KxEpdjyMRAmEPAKDUame55tLUcfBmlHZzLw2B8v06hACgjQgN
vOWNCpSbLXI89ROatHwgOwM=
=zQ7Z
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Lars Weiler]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

* Jeffrey Gardner <je_fro@gentoo.org> [07/09/24 10:12 -0500]:
> Please keep the commit reviews coming on gentoo-dev.

I will not change that.  The bug requests to send the
commit review to the original author as well.  That
decreases manual work for our main-reviewers as they
currently have to add the author into Cc manually.

Regards, Lars

-- 
Lars Weiler  <pylon@gentoo.org>  +49-171-1963258
Instant Messaging     : pylon@jabber.ccc.de
Gentoo Linux PowerPC  : Developer
Gentoo Infrastructure : CVS/SVN Administrator

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On Mon, Sep 24, 2007 at 11:40:40AM +0200, Lars Weiler wrote:
> * Robin H. Johnson <robbat2@gentoo.org> [07/09/18 17:23 -0700]:
> > Reply-To on gentoo-commits is already set to gentoo-dev@lists.g.o
> I guess this is set by the mailing-list-software?  That
> collides with https://bugs.gentoo.org/193376.
That was filed after the original creations of the commit mail system.
Anyway, it's moot now, I updated the code to set Reply-To to both the
list and the committer per that bug.

However that is still going to suck, because now folk that ARE
subscribed to gentoo-dev that get commit-reviewed are going to get
duplicates. Additionally, responses after the first review that are on
the list won't be seen by a non-subscribed dev.

-- 
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail     : robbat2@gentoo.org
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85

[-- Attachment #2: Type: application/pgp-signature, Size: 321 bytes --]

Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

On Tuesday 25 September 2007, Robin H. Johnson wrote:
> However that is still going to suck, because now folk that ARE
> subscribed to gentoo-dev that get commit-reviewed are going to get
> duplicates.

i dont think so ... i'm pretty sure the default mailer settings are to not 
post duplicates

at least, i dont recall ever seeing duplicates when someone e-mailed 
gentoo-dev and cc-ed me

> Additionally, responses after the first review that are on 
> the list won't be seen by a non-subscribed dev.

reply-all !
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]