From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org)
by nuthatch.gentoo.org with esmtp (Exim 4.67)
(envelope-from <gentoo-dev+bounces-25782-garchives=archives.gentoo.org@gentoo.org>)
id 1IIAzn-0002T3-ET
for garchives@archives.gentoo.org; Mon, 06 Aug 2007 22:24:15 +0000
Received: from robin.gentoo.org (localhost [127.0.0.1])
by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l76MNCdR019204;
Mon, 6 Aug 2007 22:23:12 GMT
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l76ML8uk016872
for <gentoo-dev@lists.gentoo.org>; Mon, 6 Aug 2007 22:21:09 GMT
Received: from localhost (xray.science.oregonstate.edu [128.193.220.51])
(using TLSv1 with cipher AES128-SHA (128/128 bits))
(No client certificate requested)
by smtp.gentoo.org (Postfix) with ESMTP id BDA2C65610
for <gentoo-dev@lists.gentoo.org>; Mon, 6 Aug 2007 22:21:08 +0000 (UTC)
Date: Mon, 6 Aug 2007 15:21:22 -0700
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] RFC: new gnustep eclasses
Message-ID: <20070806222122.GA27510@comet>
References: <20070807000413.22d7849d@enterprise.cafarelli.fr>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070807000413.22d7849d@enterprise.cafarelli.fr>
User-Agent: Mutt/1.5.16 (2007-06-09)
X-Archives-Salt: 9cd1d4fb-e91c-49d2-879f-50b43f77decb
X-Archives-Hash: 0a445e734c98d206d4dcb86591fb64d6
On 00:04 Tue 07 Aug , Bernard Cafarelli wrote:
> Latest version of the base eclass (sent with this mail) can be found at:
> http://overlays.gentoo.org/proj/gnustep/browser/overlay/eclass/gnustep-base.eclass
>
> This one does most of the hard work, especially in egnustep_env which
> sets up an appropriate GNUstep compilation environment from the
> installed gnustep-make.
Some suggestions on the eclass ...
Instead of your eval trick, try something like what's in molden-4.6.ebuild:
typeset -a args
args=( CC="$(tc-getCC) ${CFLAGS}" \
FC="${FORTRANC}" LDR="${FORTRANC}" FFLAGS="${FFLAGS}" )
emake -j1 "${args[@]}" || die "molden emake failed"
Some of your die() calls lack messages. Please add them.
I like a little different setup for this type of function:
117 egnustep_make() {
118 if [ -f ./[mM]akefile -o -f ./GNUmakefile ] ; then
119 eval emake ${*} ${__GS_MAKE_EVAL} all || die "package make failed"
120 else
121 die "no Makefile found"
122 fi
123 }
Instead...
117 egnustep_make() {
118 if [ -f ./[mM]akefile -o -f ./GNUmakefile ] ; then
119 eval emake ${*} ${__GS_MAKE_EVAL} all || die "package make failed"
120 return 0
121 fi
122 die "no Makefile found"
123 }
But that's just a matter of preference. Same kinda deal for egnustep_install().
Thanks,
Donnie
--
gentoo-dev@gentoo.org mailing list