Re: [gentoo-dev] RFC: new gnustep eclasses

[Donnie Berkholz <dberkholz@gentoo.org>]

On 00:04 Tue 07 Aug     , Bernard Cafarelli wrote:
> Latest version of the base eclass (sent with this mail) can be found at:
> http://overlays.gentoo.org/proj/gnustep/browser/overlay/eclass/gnustep-base.eclass
> 
> This one does most of the hard work, especially in egnustep_env which
> sets up an appropriate GNUstep compilation environment from the
> installed gnustep-make.

Some suggestions on the eclass ...

Instead of your eval trick, try something like what's in molden-4.6.ebuild:

    typeset -a args
    args=( CC="$(tc-getCC) ${CFLAGS}" \
        FC="${FORTRANC}" LDR="${FORTRANC}" FFLAGS="${FFLAGS}" )

    emake -j1 "${args[@]}" || die "molden emake failed"

Some of your die() calls lack messages. Please add them.

I like a little different setup for this type of function:
117 	egnustep_make() {
118 	        if [ -f ./[mM]akefile -o -f ./GNUmakefile ] ; then
119 	                eval emake ${*} ${__GS_MAKE_EVAL} all || die "package make failed"
120 	        else
121 	                die "no Makefile found"
122 	        fi
123 	}

Instead...
117 	egnustep_make() {
118 	        if [ -f ./[mM]akefile -o -f ./GNUmakefile ] ; then
119 	                eval emake ${*} ${__GS_MAKE_EVAL} all || die "package make failed"
120 	                return 0
121 	        fi
122 	        die "no Makefile found"
123 	}

But that's just a matter of preference. Same kinda deal for egnustep_install().

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list